Facilities transfer is not atomic?

[BCerki]

Describe the Bug:

There are some transfer-related services that don't have @transaction.atomic(). Probably we want this, but the only weird behaviour I've been able to trigger so far is:

If something goes wrong with a facility transfer that happened in the past, the transfer record is created but the transfer doesn't happen.

For example, on this branch I threw an exception partway through _process_facilities_transfer:

When I went back to the grid, I saw a record for my failed transfer, but the facility wasn't actually moved:

There are some transfer-related services that don't have @transaction.atomic(), maybe that's part of it?

Probability:

(How likely the bug is to happen, scored from 1-5. For example, probability of 5 is something like "it happens to all users every time they log in." whereas probability of 1 "only happens to certain users when a really specific and unlikely path is followed.")

Impact:

(How bad the bug is when it does happen, scored from 1-5. For example, effect of 5 is "the entire app crashes and makes it unusable for all users" or "the bug causes the wrong data to be saved, with critical information (e.g. payment) being affected." whereas effect of 1 is "It makes some styling look a little bit weird.")

Steps to reproduce the behaviour:

1. Step Lets use common phrasing #1
2. Step Add missing topics #2
3. Step Add project lifecycle badge #3

Screenshots:

Additional information:

OS: [e.g. iOS]
Browser: [e.g. chrome, safari]
Version: [e.g. 22]

Additional Context