Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Messages not being delivered by the webhook logging when the message contains double quotes #95

Closed
WadeBarnes opened this issue Dec 27, 2022 · 2 comments · Fixed by #96
Assignees
Labels
bug Something isn't working

Comments

@WadeBarnes
Copy link
Member

In the following example the error message does not get posted to the rocket.chat webhook endpoint as expected due to the double quotes in the message, specifically in "base/16386/3897249", not being properly url encoded before being sent.

Verifying backup ...

Settings:
- Database: event-db-primary:5432/bc_reg_db
- Backup file: /backups/daily/2022-12-26/event-db-primary-bc_reg_db_2022-12-26_01-00-00.sql.gz

Already clean ...

waiting for server to start....................................................
The server started in 0h:0m:52s.

Restoring from backup ...
waiting for server to shut down.... done
server stopped
Cleaning up ...

[!!ERROR!!] - Backup verification failed: /backups/daily/2022-12-26/event-db-primary-bc_reg_db_2022-12-26_01-00-00.sql.gz

The following issues were encountered during backup verification;
Restoring '/backups/daily/2022-12-26/event-db-primary-bc_reg_db_2022-12-26_01-00-00.sql.gz' to '127.0.0.1/bc_reg_db' ...

PANIC: could not fsync file "base/16386/3897249": No space left on device
server closed the connection unexpectedly
This probably means the server terminated abnormally
before or while processing the request.
connection to server was lost

Restore failed.

Elapsed time: 0h:43m:9s - Status Code: 2

Observed behavior:

  • The error message never appears in the associated rocket.chat channel.

Expected behavior:

  • The error message is successfully delivered and displayed in the associated rocket.chat channel.
@WadeBarnes
Copy link
Member Author

Manual testing was performed to ensure the webhook logging functioned for the reported case as well as existing info and error causes.

Built and deployed new container into affected environment. Running a verification to recreate the issue and verify the message is sent to the expected RC channel successfully.

@WadeBarnes
Copy link
Member Author

Testing complete. The error message was posted as expected:
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant