Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update cron job to use apiVersion: "batch/v1" #104

Closed
pbolduc opened this issue Mar 10, 2023 · 7 comments · Fixed by #105
Closed

Update cron job to use apiVersion: "batch/v1" #104

pbolduc opened this issue Mar 10, 2023 · 7 comments · Fixed by #105
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@pbolduc
Copy link

pbolduc commented Mar 10, 2023

Kubernetes introduced batch/v1 API version in 1.21. The batch/v1beta1 API version of CronJob is no longer served as of v1.25. The next version of OpenShift, 4.12 uses Kubernetes 1.25. OpenShift 4.12 was released around February 1, 2023. It will be the next version deployed to BC Gov OpenShift at sometime in the future. To avoid uses of this backup container breaking, it should move to using the new API version.

See: Deprecated API Migration Guide 1.25

@WadeBarnes
Copy link
Member

@LawrenceLau2020, is this related to the message you sent me?

@WadeBarnes WadeBarnes added help wanted Extra attention is needed good first issue Good for newcomers labels Mar 31, 2023
@WadeBarnes
Copy link
Member

@pbolduc, @LawrenceLau2020, Feel free to make the updates, test things out, and submit a PR. This is a community driven project.

@pbolduc
Copy link
Author

pbolduc commented Mar 31, 2023

It is a simple change, however, I currently do not have a deployment in place to test. I mainly created the issue to bring the removal to the attention of those who do have this deployment.

@WadeBarnes
Copy link
Member

@LawrenceLau2020, do you have a place to test this?

@LawrenceLau2020
Copy link

Yes, we might be able to test this in our dev environment in OCP.

@WadeBarnes
Copy link
Member

After a little investigation with @LawrenceLau2020, it turns out his concern is not related to the upgrade of the k8s version affecting the CronJob API version, but with the API version of a Tekton task they're using with the backup container. Separate component, separate release schedule ... separate concern.

@WadeBarnes
Copy link
Member

PR submitted with the update.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants