From 46e59fc5595f0d4f8ff467f23641ea4f05a94a6d Mon Sep 17 00:00:00 2001 From: Marco Bertschi Date: Fri, 15 Nov 2019 14:47:48 +0100 Subject: [PATCH] Make constructor of internal classes public (or public classes internal with public constructor), where needed. --- .../TestTools/TestIoContainer.cs | 5 +---- src/BBT.StructureTools/Compare/CompareHelper.cs | 7 +++++++ src/BBT.StructureTools/Compare/Comparer.cs | 2 +- .../Compare/Helper/EqualityComparerHelperOperations.cs | 2 +- .../Compare/Helper/EqualityComparerHelperRegistration.cs | 2 +- src/BBT.StructureTools/Compare/TypeComparer.cs | 7 +++++++ src/BBT.StructureTools/Convert/ConvertEngine.cs | 2 +- src/BBT.StructureTools/Convert/ConvertHelper.cs | 9 ++++++++- src/BBT.StructureTools/Convert/Converter.cs | 4 ++-- .../Convert/Strategy/ConvertStrategyProvider.cs | 7 +++++++ .../Convert/Strategy/OperationCopySource.cs | 7 +++++++ .../Convert/Strategy/OperationCopyValue.cs | 7 +++++++ .../Strategy/OperationCopyValueIfSourceNotDefault.cs | 7 +++++++ .../Strategy/OperationCopyValueIfTargetIsDefault.cs | 7 +++++++ .../Convert/Strategy/OperationCopyValueWithLookup.cs | 7 +++++++ .../Strategy/OperationCopyValueWithSourceFilter.cs | 7 +++++++ .../Convert/Strategy/OperationCopyValueWithUpperLimit.cs | 7 +++++++ .../OperationCreateFromSourceWithReverseRelation.cs | 7 +++++++ .../Convert/Strategy/OperationCreateToOne.cs | 7 +++++++ .../Strategy/OperationCreateToOneWithReverseRelation.cs | 7 +++++++ .../Convert/Value/ConvertValueRegistration.cs | 7 +++++++ .../Convert/Value/ValueConvertMapping.cs | 7 +++++++ src/BBT.StructureTools/Copy/Helper/CopyHelper.cs | 7 +++++++ src/BBT.StructureTools/Copy/Helper/CopyHelperFactory.cs | 7 +++++++ .../Copy/Helper/CopyHelperOperations.cs | 2 +- .../Copy/Helper/CopyHelperRegistrationFactory.cs | 7 +++++++ .../Copy/Operation/CopyOperationCreateFromFactory.cs | 7 +++++++ .../CopyOperationCreateToManyWithReverseRelation.cs | 7 +++++++ .../CopyOperationCreateToOneWithReverseRelation.cs | 7 +++++++ .../Operation/CopyOperationCrossReferenceProcessing.cs | 7 +++++++ 30 files changed, 170 insertions(+), 12 deletions(-) diff --git a/src/BBT.StructureTools.Tests/TestTools/TestIoContainer.cs b/src/BBT.StructureTools.Tests/TestTools/TestIoContainer.cs index fe75cb9..ef8faf5 100644 --- a/src/BBT.StructureTools.Tests/TestTools/TestIoContainer.cs +++ b/src/BBT.StructureTools.Tests/TestTools/TestIoContainer.cs @@ -23,10 +23,7 @@ public static class TestIoContainer /// public static IKernel Initialize() { - var settings = new NinjectSettings - { - InjectNonPublic = true, - }; + var settings = new NinjectSettings(); var kernel = new StandardKernel(settings); diff --git a/src/BBT.StructureTools/Compare/CompareHelper.cs b/src/BBT.StructureTools/Compare/CompareHelper.cs index ee69758..51e780a 100644 --- a/src/BBT.StructureTools/Compare/CompareHelper.cs +++ b/src/BBT.StructureTools/Compare/CompareHelper.cs @@ -7,6 +7,13 @@ /// internal class CompareHelper : ICompareHelper { + /// + /// Initializes a new instance of the class. + /// + public CompareHelper() + { + } + /// public void DoComparePostProcessing( T candidate1Nullable, diff --git a/src/BBT.StructureTools/Compare/Comparer.cs b/src/BBT.StructureTools/Compare/Comparer.cs index 5add3f5..0f85227 100644 --- a/src/BBT.StructureTools/Compare/Comparer.cs +++ b/src/BBT.StructureTools/Compare/Comparer.cs @@ -16,7 +16,7 @@ internal class Comparer : IComparer /// /// Initializes a new instance of the class. /// - internal Comparer( + public Comparer( ICompareRegistrations compareRegistrations, IEqualityComparerHelperRegistrationFactory factory, ICompareHelper compareHelper) diff --git a/src/BBT.StructureTools/Compare/Helper/EqualityComparerHelperOperations.cs b/src/BBT.StructureTools/Compare/Helper/EqualityComparerHelperOperations.cs index 09850ab..512d005 100644 --- a/src/BBT.StructureTools/Compare/Helper/EqualityComparerHelperOperations.cs +++ b/src/BBT.StructureTools/Compare/Helper/EqualityComparerHelperOperations.cs @@ -15,7 +15,7 @@ internal class EqualityComparerHelperOperations : IEqualityComparerHelpe /// /// Initializes a new instance of the class. /// - internal EqualityComparerHelperOperations(IEnumerable> registeredStrategies) + public EqualityComparerHelperOperations(IEnumerable> registeredStrategies) { registeredStrategies.NotNull(nameof(registeredStrategies)); diff --git a/src/BBT.StructureTools/Compare/Helper/EqualityComparerHelperRegistration.cs b/src/BBT.StructureTools/Compare/Helper/EqualityComparerHelperRegistration.cs index afad71c..69267cb 100644 --- a/src/BBT.StructureTools/Compare/Helper/EqualityComparerHelperRegistration.cs +++ b/src/BBT.StructureTools/Compare/Helper/EqualityComparerHelperRegistration.cs @@ -8,7 +8,7 @@ using BBT.StructureTools.Extension; /// - public class EqualityComparerHelperRegistration : IEqualityComparerHelperRegistration + internal class EqualityComparerHelperRegistration : IEqualityComparerHelperRegistration where T : class { private readonly ICollection> registeredStrategies; diff --git a/src/BBT.StructureTools/Compare/TypeComparer.cs b/src/BBT.StructureTools/Compare/TypeComparer.cs index 7353e8b..a9f5111 100644 --- a/src/BBT.StructureTools/Compare/TypeComparer.cs +++ b/src/BBT.StructureTools/Compare/TypeComparer.cs @@ -12,6 +12,13 @@ /// internal sealed class TypeComparer : IComparer { + /// + /// Initializes a new instance of the class. + /// + public TypeComparer() + { + } + /// public int Compare(Type x, Type y) { diff --git a/src/BBT.StructureTools/Convert/ConvertEngine.cs b/src/BBT.StructureTools/Convert/ConvertEngine.cs index b2fab76..7515ebb 100644 --- a/src/BBT.StructureTools/Convert/ConvertEngine.cs +++ b/src/BBT.StructureTools/Convert/ConvertEngine.cs @@ -1,7 +1,7 @@ namespace BBT.StructureTools.Convert { /// - public class ConvertEngine : IConvertEngine + internal class ConvertEngine : IConvertEngine where TSource : class where TTarget : class { diff --git a/src/BBT.StructureTools/Convert/ConvertHelper.cs b/src/BBT.StructureTools/Convert/ConvertHelper.cs index f5753dd..cdf18da 100644 --- a/src/BBT.StructureTools/Convert/ConvertHelper.cs +++ b/src/BBT.StructureTools/Convert/ConvertHelper.cs @@ -5,8 +5,15 @@ using BBT.StructureTools.Extension; /// - public class ConvertHelper : IConvertHelper + internal class ConvertHelper : IConvertHelper { + /// + /// Initializes a new instance of the class. + /// + public ConvertHelper() + { + } + /// public void DoConvertPreProcessing( TSourceClass source, diff --git a/src/BBT.StructureTools/Convert/Converter.cs b/src/BBT.StructureTools/Convert/Converter.cs index 518f813..f7644e8 100644 --- a/src/BBT.StructureTools/Convert/Converter.cs +++ b/src/BBT.StructureTools/Convert/Converter.cs @@ -4,7 +4,7 @@ using BBT.StructureTools.Extension; /// - public class Converter : IConvert + internal class Converter : IConvert where TSource : class where TTarget : class where TConvertIntention : IBaseConvertIntention @@ -15,7 +15,7 @@ public class Converter : IConvert /// Initializes a new instance of the class. /// - internal Converter( + public Converter( IConvertRegistrations convertRegistrations, IConvertEngine convertEngine, IConvertHelper convertHelper) diff --git a/src/BBT.StructureTools/Convert/Strategy/ConvertStrategyProvider.cs b/src/BBT.StructureTools/Convert/Strategy/ConvertStrategyProvider.cs index 9387b16..0fc3dbc 100644 --- a/src/BBT.StructureTools/Convert/Strategy/ConvertStrategyProvider.cs +++ b/src/BBT.StructureTools/Convert/Strategy/ConvertStrategyProvider.cs @@ -8,6 +8,13 @@ internal class ConvertStrategyProvider : IConvertStrategyProvider where TIntention : IBaseConvertIntention { + /// + /// Initializes a new instance of the class. + /// + public ConvertStrategyProvider() + { + } + /// public ISourceConvertStrategy GetConvertStrategyFromSource(TSource source) { diff --git a/src/BBT.StructureTools/Convert/Strategy/OperationCopySource.cs b/src/BBT.StructureTools/Convert/Strategy/OperationCopySource.cs index c53354f..f2ace27 100644 --- a/src/BBT.StructureTools/Convert/Strategy/OperationCopySource.cs +++ b/src/BBT.StructureTools/Convert/Strategy/OperationCopySource.cs @@ -13,6 +13,13 @@ internal class OperationCopySource { private Expression> targetExpression; + /// + /// Initializes a new instance of the class. + /// + public OperationCopySource() + { + } + /// public void Initialize(Expression> targetExpression) { diff --git a/src/BBT.StructureTools/Convert/Strategy/OperationCopyValue.cs b/src/BBT.StructureTools/Convert/Strategy/OperationCopyValue.cs index 5099e01..84a6bbc 100644 --- a/src/BBT.StructureTools/Convert/Strategy/OperationCopyValue.cs +++ b/src/BBT.StructureTools/Convert/Strategy/OperationCopyValue.cs @@ -14,6 +14,13 @@ internal class OperationCopyValue private Func sourceFunc; private Expression> targetExpression; + /// + /// Initializes a new instance of the class. + /// + public OperationCopyValue() + { + } + /// public void Initialize( Func sourceFunc, diff --git a/src/BBT.StructureTools/Convert/Strategy/OperationCopyValueIfSourceNotDefault.cs b/src/BBT.StructureTools/Convert/Strategy/OperationCopyValueIfSourceNotDefault.cs index 55286c7..783cc35 100644 --- a/src/BBT.StructureTools/Convert/Strategy/OperationCopyValueIfSourceNotDefault.cs +++ b/src/BBT.StructureTools/Convert/Strategy/OperationCopyValueIfSourceNotDefault.cs @@ -14,6 +14,13 @@ internal class OperationCopyValueIfSourceNotDefault private Func sourceFunc; private Expression> targetExpression; + /// + /// Initializes a new instance of the class. + /// + public OperationCopyValueIfSourceNotDefault() + { + } + /// public void Initialize( Func aSourceFunc, diff --git a/src/BBT.StructureTools/Convert/Strategy/OperationCopyValueIfTargetIsDefault.cs b/src/BBT.StructureTools/Convert/Strategy/OperationCopyValueIfTargetIsDefault.cs index 92101ef..f594de3 100644 --- a/src/BBT.StructureTools/Convert/Strategy/OperationCopyValueIfTargetIsDefault.cs +++ b/src/BBT.StructureTools/Convert/Strategy/OperationCopyValueIfTargetIsDefault.cs @@ -14,6 +14,13 @@ internal class OperationCopyValueIfTargetIsDefault private Func sourceFunc; private Expression> targetExpression; + /// + /// Initializes a new instance of the class. + /// + public OperationCopyValueIfTargetIsDefault() + { + } + /// public void Initialize( Func aSourceFunc, diff --git a/src/BBT.StructureTools/Convert/Strategy/OperationCopyValueWithLookup.cs b/src/BBT.StructureTools/Convert/Strategy/OperationCopyValueWithLookup.cs index 117ef47..313d783 100644 --- a/src/BBT.StructureTools/Convert/Strategy/OperationCopyValueWithLookup.cs +++ b/src/BBT.StructureTools/Convert/Strategy/OperationCopyValueWithLookup.cs @@ -15,6 +15,13 @@ internal class OperationCopyValueWithLookUp private Func sourceLookupFunc; private Expression> targetExpression; + /// + /// Initializes a new instance of the class. + /// + public OperationCopyValueWithLookUp() + { + } + /// public void Initialize( Func aSourceFunc, diff --git a/src/BBT.StructureTools/Convert/Strategy/OperationCopyValueWithSourceFilter.cs b/src/BBT.StructureTools/Convert/Strategy/OperationCopyValueWithSourceFilter.cs index d93cc2d..0fa79d4 100644 --- a/src/BBT.StructureTools/Convert/Strategy/OperationCopyValueWithSourceFilter.cs +++ b/src/BBT.StructureTools/Convert/Strategy/OperationCopyValueWithSourceFilter.cs @@ -14,6 +14,13 @@ internal class OperationCopyValueWithSourceFilter private Func sourceFunc; private Expression> targetExpression; + /// + /// Initializes a new instance of the class. + /// + public OperationCopyValueWithSourceFilter() + { + } + /// public void Initialize( Func sourceFunc, diff --git a/src/BBT.StructureTools/Convert/Strategy/OperationCopyValueWithUpperLimit.cs b/src/BBT.StructureTools/Convert/Strategy/OperationCopyValueWithUpperLimit.cs index bc2959f..be94b2c 100644 --- a/src/BBT.StructureTools/Convert/Strategy/OperationCopyValueWithUpperLimit.cs +++ b/src/BBT.StructureTools/Convert/Strategy/OperationCopyValueWithUpperLimit.cs @@ -16,6 +16,13 @@ internal class OperationCopyValueWithUpperLimit private Func sourceUpperLimitFunc; private Expression> targetExpression; + /// + /// Initializes a new instance of the class. + /// + public OperationCopyValueWithUpperLimit() + { + } + /// public void Initialize( Func aSourceFunc, diff --git a/src/BBT.StructureTools/Convert/Strategy/OperationCreateFromSourceWithReverseRelation.cs b/src/BBT.StructureTools/Convert/Strategy/OperationCreateFromSourceWithReverseRelation.cs index a09a06f..e8c4c48 100644 --- a/src/BBT.StructureTools/Convert/Strategy/OperationCreateFromSourceWithReverseRelation.cs +++ b/src/BBT.StructureTools/Convert/Strategy/OperationCreateFromSourceWithReverseRelation.cs @@ -18,6 +18,13 @@ internal class OperationCreateFromSourceWithReverseRelation createConvertHelper; private Expression> targetExpression; + /// + /// Initializes a new instance of the class. + /// + public OperationCreateFromSourceWithReverseRelation() + { + } + /// public void Initialize( Expression> targetExpression, diff --git a/src/BBT.StructureTools/Convert/Strategy/OperationCreateToOne.cs b/src/BBT.StructureTools/Convert/Strategy/OperationCreateToOne.cs index c750768..5a13bec 100644 --- a/src/BBT.StructureTools/Convert/Strategy/OperationCreateToOne.cs +++ b/src/BBT.StructureTools/Convert/Strategy/OperationCreateToOne.cs @@ -20,6 +20,13 @@ internal class OperationCreateToOne> targetExpression; private ICreateConvertHelper createConvertHelper; + /// + /// Initializes a new instance of the class. + /// + public OperationCreateToOne() + { + } + /// public void Initialize( Func sourceFunc, diff --git a/src/BBT.StructureTools/Convert/Strategy/OperationCreateToOneWithReverseRelation.cs b/src/BBT.StructureTools/Convert/Strategy/OperationCreateToOneWithReverseRelation.cs index a0ca505..6e10082 100644 --- a/src/BBT.StructureTools/Convert/Strategy/OperationCreateToOneWithReverseRelation.cs +++ b/src/BBT.StructureTools/Convert/Strategy/OperationCreateToOneWithReverseRelation.cs @@ -20,6 +20,13 @@ internal class OperationCreateToOneWithReverseRelation> targetExpression; private ICreateConvertHelper createConvertHelper; + /// + /// Initializes a new instance of the class. + /// + public OperationCreateToOneWithReverseRelation() + { + } + /// public void Initialize( Func sourceFunc, diff --git a/src/BBT.StructureTools/Convert/Value/ConvertValueRegistration.cs b/src/BBT.StructureTools/Convert/Value/ConvertValueRegistration.cs index fbd24a2..8690780 100644 --- a/src/BBT.StructureTools/Convert/Value/ConvertValueRegistration.cs +++ b/src/BBT.StructureTools/Convert/Value/ConvertValueRegistration.cs @@ -5,6 +5,13 @@ internal class ConvertValueRegistration : IConvertValueRegistr { private readonly IValueConvertMapping valueConvertMapping = new ValueConvertMapping(); + /// + /// Initializes a new instance of the class. + /// + public ConvertValueRegistration() + { + } + /// public IConvertValueRegistration Register(TSource sourceValue, TTarget targetValue) { diff --git a/src/BBT.StructureTools/Convert/Value/ValueConvertMapping.cs b/src/BBT.StructureTools/Convert/Value/ValueConvertMapping.cs index a58e7f3..0225b34 100644 --- a/src/BBT.StructureTools/Convert/Value/ValueConvertMapping.cs +++ b/src/BBT.StructureTools/Convert/Value/ValueConvertMapping.cs @@ -10,6 +10,13 @@ internal class ValueConvertMapping : IValueConvertMapping mapToException = new HashSet(); private Func nullCaseFunc; + /// + /// Initializes a new instance of the class. + /// + public ValueConvertMapping() + { + } + /// public void AddException(TSource sourceValue) { diff --git a/src/BBT.StructureTools/Copy/Helper/CopyHelper.cs b/src/BBT.StructureTools/Copy/Helper/CopyHelper.cs index 1e33712..31929b0 100644 --- a/src/BBT.StructureTools/Copy/Helper/CopyHelper.cs +++ b/src/BBT.StructureTools/Copy/Helper/CopyHelper.cs @@ -9,6 +9,13 @@ /// internal class CopyHelper : ICopyHelper { + /// + /// Initializes a new instance of the class. + /// + public CopyHelper() + { + } + /// public void DoCopyPostProcessing( TClassToCopy source, diff --git a/src/BBT.StructureTools/Copy/Helper/CopyHelperFactory.cs b/src/BBT.StructureTools/Copy/Helper/CopyHelperFactory.cs index ddd731c..c4848e5 100644 --- a/src/BBT.StructureTools/Copy/Helper/CopyHelperFactory.cs +++ b/src/BBT.StructureTools/Copy/Helper/CopyHelperFactory.cs @@ -12,6 +12,13 @@ internal class CopyHelperFactory where TTarget : class where TConcreteTarget : class, TTarget, new() { + /// + /// Initializes a new instance of the class. + /// + public CopyHelperFactory() + { + } + /// public ICreateCopyHelper GetCopyHelper( Expression> reverseRelationFunc) diff --git a/src/BBT.StructureTools/Copy/Helper/CopyHelperOperations.cs b/src/BBT.StructureTools/Copy/Helper/CopyHelperOperations.cs index 63eeeed..4530fd1 100644 --- a/src/BBT.StructureTools/Copy/Helper/CopyHelperOperations.cs +++ b/src/BBT.StructureTools/Copy/Helper/CopyHelperOperations.cs @@ -13,7 +13,7 @@ internal class CopyHelperOperations : ICopyOperation /// /// Initializes a new instance of the class. /// - internal CopyHelperOperations(IEnumerable> registeredStrategies) + public CopyHelperOperations(IEnumerable> registeredStrategies) { registeredStrategies.NotNull(nameof(registeredStrategies)); diff --git a/src/BBT.StructureTools/Copy/Helper/CopyHelperRegistrationFactory.cs b/src/BBT.StructureTools/Copy/Helper/CopyHelperRegistrationFactory.cs index 4d4c025..ec308db 100644 --- a/src/BBT.StructureTools/Copy/Helper/CopyHelperRegistrationFactory.cs +++ b/src/BBT.StructureTools/Copy/Helper/CopyHelperRegistrationFactory.cs @@ -5,6 +5,13 @@ /// internal class CopyHelperRegistrationFactory : ICopyHelperRegistrationFactory { + /// + /// Initializes a new instance of the class. + /// + public CopyHelperRegistrationFactory() + { + } + /// /// Creates an instance of CopyHelperRegistration. /// diff --git a/src/BBT.StructureTools/Copy/Operation/CopyOperationCreateFromFactory.cs b/src/BBT.StructureTools/Copy/Operation/CopyOperationCreateFromFactory.cs index 9954865..3f093f9 100644 --- a/src/BBT.StructureTools/Copy/Operation/CopyOperationCreateFromFactory.cs +++ b/src/BBT.StructureTools/Copy/Operation/CopyOperationCreateFromFactory.cs @@ -17,6 +17,13 @@ internal class CopyOperationCreateFromFactory private TAttributeValueFactory attributeValueFactory; + /// + /// Initializes a new instance of the class. + /// + public CopyOperationCreateFromFactory() + { + } + /// public void Copy(T source, T target, ICopyCallContext copyCallContext) { diff --git a/src/BBT.StructureTools/Copy/Operation/CopyOperationCreateToManyWithReverseRelation.cs b/src/BBT.StructureTools/Copy/Operation/CopyOperationCreateToManyWithReverseRelation.cs index f8863ac..a9c8864 100644 --- a/src/BBT.StructureTools/Copy/Operation/CopyOperationCreateToManyWithReverseRelation.cs +++ b/src/BBT.StructureTools/Copy/Operation/CopyOperationCreateToManyWithReverseRelation.cs @@ -18,6 +18,13 @@ internal class CopyOperationCreateToManyWithReverseRelation> sourceFunc; private Maybe>>> maybeTargetExpression; + /// + /// Initializes a new instance of the class. + /// + public CopyOperationCreateToManyWithReverseRelation() + { + } + /// public void Initialize( Func> sourceFunc, diff --git a/src/BBT.StructureTools/Copy/Operation/CopyOperationCreateToOneWithReverseRelation.cs b/src/BBT.StructureTools/Copy/Operation/CopyOperationCreateToOneWithReverseRelation.cs index 4524c10..8b2c9e5 100644 --- a/src/BBT.StructureTools/Copy/Operation/CopyOperationCreateToOneWithReverseRelation.cs +++ b/src/BBT.StructureTools/Copy/Operation/CopyOperationCreateToOneWithReverseRelation.cs @@ -17,6 +17,13 @@ internal class CopyOperationCreateToOneWithReverseRelation createCopyHelper; + /// + /// Initializes a new instance of the class. + /// + public CopyOperationCreateToOneWithReverseRelation() + { + } + /// public void Initialize( Func sourceFunc, diff --git a/src/BBT.StructureTools/Copy/Operation/CopyOperationCrossReferenceProcessing.cs b/src/BBT.StructureTools/Copy/Operation/CopyOperationCrossReferenceProcessing.cs index 64aeb35..87124d5 100644 --- a/src/BBT.StructureTools/Copy/Operation/CopyOperationCrossReferenceProcessing.cs +++ b/src/BBT.StructureTools/Copy/Operation/CopyOperationCrossReferenceProcessing.cs @@ -14,6 +14,13 @@ internal class CopyOperationCrossReferenceProcessing> referencingPropertyExpression; + /// + /// Initializes a new instance of the class. + /// + public CopyOperationCrossReferenceProcessing() + { + } + /// public void Initialize( Expression> referencingProperty)