Replies: 2 comments
-
Hi, Du kannst einfach das repo forken, da deine Änderungen machen und dann einen Pull Request erstellen. Dann kann ich das sehen. Leider hab ich keine Ahnung von Python packaging, aber an sich klingt die Idee super. Versuchs einfach mal. |
Beta Was this translation helpful? Give feedback.
-
Servus, ich hab mich einmal an einem Pull Requst versucht, mein erster Beitrag zu einem Github Repository 💪 |
Beta Was this translation helpful? Give feedback.
-
Hello @bb-Ricardo!
I write in english although i am from Austria, i expect you are German but not sure.
I found the check_redfish python script when i was looking for possibilities to monitor our DELL servers. The script works very well, but has limitations for my automation platform (Ansible / AWX), it is not as simple to install as expected. In my ansible playbooks i can only deploy pyton packages from repository servers.
I think it would be a very helpful feature to package the check_redfish project o a python package and install it with PIP.
I made some small changes to the cloned repository wich are working in my environment, so i want to ask you to implement that changes to your future releases.
I am not as familiar how to contribute or work together with github, so i tried to push my branch to your repository, but i think i have no permissions doing that.
Dan you grant me permissions to push my changes to your repository and review my changes, i focused on not doing breaking changes can make as less changes as possible to your code.
After applying my changes you have the following new features:
The features above are based on poetry, i added a "README_TMP.md" file where things are documented, since my focus was making as less code changes as possible it is not perfect, but can easily be adopted by you and your contributors to the project.
You can revoke access to the repository for me after pushing my branch, if do do not want to grant access please let me know how i could give my changes to you for review and hopefully merging them to your project.
I wish you a wonderfull weedend
Markus (@pombaer)
Beta Was this translation helpful? Give feedback.
All reactions