From c1fdbcf23e66db1926fc7b48cd262ca09050fc00 Mon Sep 17 00:00:00 2001 From: Eric Amorde Date: Tue, 17 Dec 2024 18:26:29 -0800 Subject: [PATCH] Revert "Avoid calling to_list in _get_cc_info_linker_inputs for performance (#930)" This reverts commit 77c4afab96331d48138f090cd1e395f4db8bd644. --- rules/framework.bzl | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/rules/framework.bzl b/rules/framework.bzl index 050e6853..9e5fcc7e 100644 --- a/rules/framework.bzl +++ b/rules/framework.bzl @@ -562,9 +562,10 @@ def _get_cc_info_linker_inputs(*, deps): if not CcInfo in dep: continue - linker_inputs.append(dep[CcInfo].linking_context.linker_inputs) + for linker_input in dep[CcInfo].linking_context.linker_inputs.to_list(): + linker_inputs.append(linker_input) - return depset([], transitive = linker_inputs) + return depset(linker_inputs) def _create_swiftmodule(attrs): kwargs = {}