Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider removing force_load_direct_deps_rule in Bazel 7+ #862

Closed
luispadron opened this issue Apr 2, 2024 · 0 comments · Fixed by #934
Closed

Consider removing force_load_direct_deps_rule in Bazel 7+ #862

luispadron opened this issue Apr 2, 2024 · 0 comments · Fixed by #934

Comments

@luispadron
Copy link
Collaborator

The flag --incompatible_objc_alwayslink_by_default should effectively do the same thing. Folks can also use alwayslink = True to be more precise.

More info: bazelbuild/rules_apple#1938
@luispadron luispadron mentioned this issue Apr 2, 2024
Merged
@ssarad ssarad mentioned this issue Dec 22, 2024
Merged
@jszumski jszumski linked a pull request Jan 14, 2025 that will close this issue
Remove references to objc_provider and remove force_load_direct_deps to support rules_apple > 3.15.0 #934
Merged
jszumski pushed a commit that referenced this issue Jan 17, 2025
@ssarad @ssaradp
Remove references to objc_provider and remove force_load_direct_deps …
6aa4540 
…to support rules_apple > 3.15.0 (#934)

1) With rules_apple removing legacy objc_providers, rules_apple > 3.15.0
is no longer compatible with rules_ios due to
bazelbuild/rules_apple#2611

2) Removing force load direct deps as its no longer needed in Bazel 7
#862

```sh
ERROR: /Users/ssarad/Bazel/BUILD.bazel:3:15: in apple_framework_packaging rule 
Traceback (most recent call last):
	File "/Users/ssarad/.bazel_cache/output/external/rules_ios~/rules/framework.bzl", line 1109, column 48, in _apple_framework_packaging_impl
		bundle_outs = _bundle_dynamic_framework(ctx, is_extension_safe = is_extension_safe, avoid_deps = avoid_deps)
	File "/Users/ssarad/.bazel_cache/output/external/rules_ios~/rules/framework.bzl", line 888, column 44, in _bundle_dynamic_framework
		partials.framework_provider_partial(
	File "/Users/ssarad/.bazel_cache/output/external/rules_apple~/apple/internal/partials/framework_provider.bzl", line 94, column 5, in framework_provider_partial
		def framework_provider_partial(
Error: framework_provider_partial() got unexpected keyword argument: objc_provider

```

This PR is attempt to make rules_ios compatible with rules_apple +
remove the legacy code to force load direct deps as with Bazel 7,
`--incompatible_objc_alwayslink_by_default` does the same thing.

---------

Co-authored-by: Sarad <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@luispadron