Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Strict mode for multiple_outputs #41

Open
bshi opened this issue Apr 2, 2018 · 3 comments
Open

Strict mode for multiple_outputs #41

bshi opened this issue Apr 2, 2018 · 3 comments

Comments

@bshi
Copy link
Contributor

bshi commented Apr 2, 2018

It would be helpful for the jsonnet_to_json rule to have an argument triggering verification that the outs enumerated in the rule matches all the output files generated from the inputs.

I was recently bit by a case where I added several output files but forgot to update my BUILD rule.

@sparkprime
Copy link
Collaborator

good idea

@mickael-carl
Copy link

Just hit this as well. It is massively confusing to see:

INFO: From Compiling Jsonnet to JSON for config:
bazel-out/k8-fastbuild/bin/bare/bb-browser.json
bazel-out/k8-fastbuild/bin/bare/bb-event-service.json
bazel-out/k8-fastbuild/bin/bare/bb-runner.json
bazel-out/k8-fastbuild/bin/bare/bb-scheduler.json
bazel-out/k8-fastbuild/bin/bare/bb-storage.json
bazel-out/k8-fastbuild/bin/bare/bb-worker.json

but actually some files not being there without any error.

@sparkprime
Copy link
Collaborator

sparkprime commented Jun 24, 2019

stdout from jsonnet is the list of file names, which should make this pretty easy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants