From 6288a6749c65bf01b2c8f51444857ecff8e21d95 Mon Sep 17 00:00:00 2001 From: "github-actions[bot]" <41898282+github-actions[bot]@users.noreply.github.com> Date: Fri, 23 Aug 2024 13:20:03 +0000 Subject: [PATCH 1/5] Create PR for #1415 From efbbd005da218d3f99b765c1ab75f4804fea1889 Mon Sep 17 00:00:00 2001 From: "Marinkov, Magdalena" Date: Fri, 23 Aug 2024 15:42:56 +0200 Subject: [PATCH 2/5] fix(close): make close button focusable by changing tabindex from -1 to 0 --- packages/core/src/components/bal-close/bal-close.tsx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/core/src/components/bal-close/bal-close.tsx b/packages/core/src/components/bal-close/bal-close.tsx index ea8fb9ebd..5d7474141 100644 --- a/packages/core/src/components/bal-close/bal-close.tsx +++ b/packages/core/src/components/bal-close/bal-close.tsx @@ -53,7 +53,7 @@ export class Close implements ComponentInterface, BalConfigObserver { type="button" aria-label={label} title={label} - tabindex={-1} + tabindex={0} class={{ ...buttonEl.class(), ...buttonEl.modifier('inverted').class(this.inverted), From 0400f90bb9ab5301e0d1f561627301e5ea5546b6 Mon Sep 17 00:00:00 2001 From: "Marinkov, Magdalena" Date: Fri, 23 Aug 2024 16:14:05 +0200 Subject: [PATCH 3/5] fix(close): make close button focusable by changing tabindex from -1 to 0 --- packages/core/src/components/bal-close/bal-close.tsx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/core/src/components/bal-close/bal-close.tsx b/packages/core/src/components/bal-close/bal-close.tsx index 5d7474141..4f2418288 100644 --- a/packages/core/src/components/bal-close/bal-close.tsx +++ b/packages/core/src/components/bal-close/bal-close.tsx @@ -53,7 +53,7 @@ export class Close implements ComponentInterface, BalConfigObserver { type="button" aria-label={label} title={label} - tabindex={0} + tabindex="0" class={{ ...buttonEl.class(), ...buttonEl.modifier('inverted').class(this.inverted), From e32bf0bf64757622f3f6bcb91c4eb6b57edc6570 Mon Sep 17 00:00:00 2001 From: Gery Hirschfeld Date: Fri, 6 Sep 2024 08:12:18 +0200 Subject: [PATCH 4/5] chore: add changeset --- .changeset/wet-cycles-report.md | 5 +++++ 1 file changed, 5 insertions(+) create mode 100644 .changeset/wet-cycles-report.md diff --git a/.changeset/wet-cycles-report.md b/.changeset/wet-cycles-report.md new file mode 100644 index 000000000..d28f81c61 --- /dev/null +++ b/.changeset/wet-cycles-report.md @@ -0,0 +1,5 @@ +--- +'@baloise/ds-core': patch +--- + +**close**: is accessible by the keyboard From 754701563ff70def4b052495b17dc543e3cb6646 Mon Sep 17 00:00:00 2001 From: Gery Hirschfeld Date: Fri, 6 Sep 2024 08:14:15 +0200 Subject: [PATCH 5/5] chore: add changeset --- .changeset/wet-cycles-report.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.changeset/wet-cycles-report.md b/.changeset/wet-cycles-report.md index d28f81c61..36fe96875 100644 --- a/.changeset/wet-cycles-report.md +++ b/.changeset/wet-cycles-report.md @@ -2,4 +2,4 @@ '@baloise/ds-core': patch --- -**close**: is accessible by the keyboard +**close**: is accessible by the keyboard