[Improvement]: Optimize BIRPackage.importModules to not contain duplicate BIRImportModule elements

[Thushara-Piyasekara]

Description

It is possible to optimize the BIRGen and Codegen phases by restricting the addition of duplicate BIRImportModule elements to the importModules attribute of BIRPackage.

As of now duplicate elements are added due to the usage of an ArrayList to hold the BIRImportModule elements.

Describe your problem(s)

These duplicate elements are being traversed by a for loop in the CodeGen phase,

This could create an unnecessary performance overhead for the compilation.

Describe your solution(s)

This process can be optimized by the usage of a HashSet instead of an ArrayList and setting up the necessary equals and hashCode functions for the BIRImportModule class. Which will prevent the addition of duplicate elements.

Related area

-> Compilation

Related issue(s) (optional)

No response

Suggested label(s) (optional)

No response

Suggested assignee(s) (optional)

No response