Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Odd behaviour when disease does not exist in supra_category #4

Open
baileythegreen opened this issue Nov 13, 2020 · 1 comment
Open

Comments

@baileythegreen
Copy link
Owner

See reported error below:

it works quite well, but i am not sure what it exactly spits out when the term doesn't exist under the selected supra category

for example: interleukin-6 receptor measurement with supracategory disease by anatomical system spits out "nervous system disease" but when you look it up in the EFO browser it comes out under information entity supracategory, it's not in anatomical system

at the same time this is in the log file: interleukin-6 measurement, chronic obstructive pulmonary disease is not a valid entry

does it currently work with partial mapping? in this case my entry traits were exactly the same as the EFO traits, so would be interested in only exact mapping. maybe that's for feature request, partial or exact mapping as an option

@baileythegreen
Copy link
Owner Author

Seems resolved, but I am not clear on what caused this to start with (and have not seen the behaviour myself).

Might have been caused by the calls to .lower() and .replace() that were being used for fuzzy matching, though this doesn't really make sense.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant