Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable nullability #96

Open
Regenhardt opened this issue Feb 29, 2024 · 3 comments
Open

Enable nullability #96

Regenhardt opened this issue Feb 29, 2024 · 3 comments

Comments

@Regenhardt
Copy link

Enabling nullability will make it easier to not accidentally pass something potentially uninitialized and also simpler to see at what point we don't have to null-check everything.

I guess immediately enabling it globally would make a mess so maybe start with enabling it in BaGetter.Protocol and putting question marks where needed, then BaGetter.Core, then look how far that branch goes without getting tired.

Just make a commit per project converted so we can merge early in order to minimize interference.

@seriouz
Copy link

seriouz commented Mar 4, 2024

I am pro on this. Because I personally like nullability very much, guarding us of Object reference not set to an instance of an object 😅.
Walking through each project sounds very logically.

Copy link

github-actions bot commented Jun 3, 2024

This issue is stale because it has been open for 90 days with no activity. Remove the stale label, comment, or this will be closed in 5 days.

Copy link

github-actions bot commented Jun 9, 2024

This issue was closed because it has been stale for 5 days with no activity.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Jun 9, 2024
@Regenhardt Regenhardt reopened this Jun 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants