Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UT-Georeferencing-Earthworks-12d-2 #50

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

UT-Georeferencing-Earthworks-12d-2 #50

wants to merge 5 commits into from

Conversation

LeeGregory12d
Copy link
Collaborator

Unit test

Cut and fill elements for bulk earthworks for a small part of a job and only semantics for the large voided object.

Covered topics

tick one/many

  • project setup
  • georeferencing
  • alignment semantics
  • alignment geometry
  • linear placement
  • project breakdown structure / spatial structure
  • terrain
  • triangulated irregular network
  • open cross profile
  • sectioned surface & solid
  • pavement & course
  • surface feature
  • earthworks
  • geotechnics
  • longitudinal products (barriers, guardrail, ...)
  • interchange
  • structural
  • drainage
  • signage
  • road furniture
  • rail furniture
  • ports & waterways furniture
  • bridge furniture

@LeeGregory12d
UT-Georeferencing-Earthworks-12d-1
6cc5364 
cut and fill elements for bulk earthworks for a small part of a job and only semantics for the voided object..
@LeeGregory12d LeeGregory12d added IFC4x3_RC2 IFC 4.3 RC2 content new New unit test labels Feb 16, 2021
@LeeGregory12d
Copy link
Collaborator Author

I'm not certain how I upset my full requests - this #50 is for UT-Georeferencing-Earthworks-12d-2

@pjanck
Copy link
Member

pjanck commented Mar 18, 2021

Following the changes to the schema, (we are now at RC3), we ask you to update your IFC files accordingly. The schema can be found here. The checking procedure for IFC files has been updated - please merge in the current state of the main branch.

@pjanck pjanck changed the title UT-Georeferencing-Earthworks-12d-1 UT-Georeferencing-Earthworks-12d-2 Mar 18, 2021
@larswik larswik mentioned this pull request Mar 19, 2021
Closed
@LeeGregory12d LeeGregory12d added IFC4x3_RC3 IFC 4.3 RC3 content and removed IFC4x3_RC2 IFC 4.3 RC2 content labels Mar 21, 2021
@larswik larswik mentioned this pull request Mar 30, 2021
Closed
AlexBrad1eyCT
AlexBrad1eyCT requested changes Apr 6, 2021
View reviewed changes
Copy link
Collaborator

@AlexBrad1eyCT AlexBrad1eyCT left a comment •
edited by pjanck
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is Fine to have the IfcSolidStratum without geometry as it would just be unwanted noise within the file, but it is currently orphaned within the structure.

  • IfcRelContainedInSpatialStructure the IfcSolidStratum under the IfcSite so it is not orphaned

@AlexBrad1eyCT AlexBrad1eyCT mentioned this pull request Apr 6, 2021
Open
@AlexBrad1eyCT AlexBrad1eyCT linked an issue Apr 6, 2021 that may be closed by this pull request
Difference between Georeferencing-Earthworks-12d-1 and Georeferencing-Earthworks-12d-2 #90
Open
@LeeGregory12d
Wrong name of IFC file in Georeferencing-Earthworks-12d-2
10b18ca 
The name of the IFC didn't match that given in the readme.md.
So change the name of the IFC file.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexBrad1eyCT AlexBrad1eyCT AlexBrad1eyCT requested changes

Assignees
No one assigned
Labels
IFC4x3_RC3 IFC 4.3 RC3 content new New unit test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Difference between Georeferencing-Earthworks-12d-1 and Georeferencing-Earthworks-12d-2
3 participants
@LeeGregory12d @pjanck @AlexBrad1eyCT