Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DrainageSystem-1 #17

Open
larswik opened this issue Feb 11, 2021 · 2 comments
Open

DrainageSystem-1 #17

larswik opened this issue Feb 11, 2021 · 2 comments
Labels
topic:drainage Topic concerns drainage tracker Discussion thread

Comments

@larswik
Copy link
Collaborator

larswik commented Feb 11, 2021

Tracker for discussions around https://github.com/bSI-InfraRoom/IFC-infra-unit-test/tree/main/DrainageSystem-1

@larswik larswik changed the title Issue tracker https://github.com/bSI-InfraRoom/IFC-infra-unit-test/tree/main/DrainageSystem-1 Issue tracker: https://github.com/bSI-InfraRoom/IFC-infra-unit-test/tree/main/DrainageSystem-1 Feb 11, 2021
@pjanck pjanck added topic:drainage Topic concerns drainage tracker Discussion thread labels Feb 11, 2021
@pjanck pjanck changed the title Issue tracker: https://github.com/bSI-InfraRoom/IFC-infra-unit-test/tree/main/DrainageSystem-1 DrainageSystem-1 Feb 11, 2021
@larswik
Copy link
Collaborator Author

larswik commented Mar 10, 2021

  • Check consistent usage of both axis and body geometry
  • Check the local placement of ports

@larswik
Copy link
Collaborator Author

larswik commented Apr 15, 2021

Physical elements contained/referenced in the spatial structure set in UT SpatialStructure-4.

  • Structure below IfcSite missing, should have at least IfcRoad, IfcFacilityPart.ROADSEGMENT, IfcFacilityPart.INTERSECTION

Should be visualised correctly compared to the supporting screenshots.

  • Ok for body representations in subcontext Body
  • Missing axis representations for manholes in subcontext Axis

Physical elements grouped into one IfcDistributionSystem, which is assigned to IfcRoad.

  • Grouping ok, but system is refeenced in IfcSIte (as IfcRoad missing)
  • Should also have the system declared in project context using IfcRelDeclares
  • Physical elements have PDT USERDEFINED, could have MANHOLE for chambers and RIGIDSEGMENT for pipes

Network topology using IfcDistributionPort and IfcRelConnectsPorts.

  • RelatingPort/RelatedPort in IfcRelConnectsPorts not used consistently for SINK and SOURCE type ports

Georeferencing

  • Should be incuded

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic:drainage Topic concerns drainage tracker Discussion thread
Projects
None yet
Development

No branches or pull requests

2 participants