Allow selenium WebElement to be passed to expect in place of a selector

[b3nj4m]

No description provided.

[benmosher]

FYI: I more or less did this in my fork. I didn't spend a ton of time verifying, and I also made it a hard requirement: no more selector strings. I think this is a little true-r to Chai/BDD testing than the original chai-webdriver code.

I'm happy to post a PR if you want, just noticed you bumped the version to 4.0. I mostly wanted to be able to use multiple WebDriver instances; passing the driver with the plugin initialization hampers this.

[b3nj4m]

What's the use-case for multiple driver instances?

[benmosher]

Iterating a test set over a different browser drivers, potentially.

I'll admit, my initial impetus for the changes in the fork stemmed from some misunderstanding of the driver lifetime; I thought it was being created/destroyed per test case. Given the spec suite for this project, that's clearly not necessary.

That said, I still like having the expect take a selection instead of a selector.

[benmosher]

As a (contrived) example: Selenium's parallel_flows.js example would not be feasible without removing the driver from the Chai helper.

[b3nj4m]

Hmm. If the driver were not supplied, selectors, and the visible function would not be usable. I don't like the inconsistency that creates in the API...

With this issue, I was thinking of allowing an element to be passed in place of a selector, but not making driver optional. Is that still useful to you?

[benmosher]

I think it is useful, but I'm using 100% Sizzle selectors and thus would need to send a meaningless driver to set up the helper with Chai. If you check out the readme on the fork, it's just expect($(selector)) in lieu of expect(selector). A worthwhile extra 3 characters to simplify the functionality, IMO. Plus, you can reuse an existing selection in multiple assertions.

I agree it's inconsistent with the existing API, for sure, but I think it might be a reasonable major-release-worthy breaking change if you liked it as an overall direction. If not, I'm pleased with my fork so far--and really appreciate your additions!