Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Incorrect text formatting #187

Open
icaca opened this issue Aug 5, 2024 · 2 comments
Open

Bug: Incorrect text formatting #187

icaca opened this issue Aug 5, 2024 · 2 comments

Comments

@icaca
Copy link

icaca commented Aug 5, 2024

Current Behaviour

The notification when entering the dungeon did not format the string correctly
image

Expected Behaviour

%s %u should be replaced correctly

Steps to reproduce the problem

Enter any copy to see the prompt

Extra Notes

No response

AutoBalance Debug Commands

No response

AC rev. hash/commit

AC> AzerothCore rev. fcdc50306ff8+ 2024-08-03 12:02:49 -0300 (master branch) (Unix, Release, Static)
Connected players: 1. Characters in world: 1.
Connection peak: 1.
服务器运行时间: 12 minute(s) 58 second(s)
Update time diff: 2ms. Last 500 diffs summary:
|- Mean: 1ms
|- Median: 2ms
|- Percentiles (95, 99, max): 3ms, 6ms, 7ms
Using SSL version: OpenSSL 3.0.2 15 Mar 2022 (library: OpenSSL 3.0.2 15 Mar 2022)
Using Boost version: 1.74.0
Using CMake version: 3.22.1
Using MySQL version: 80039
Found MySQL Executable: /usr/bin/mysql
Compiled on: Linux 4.4.0-19041-Microsoft
Worldserver listening connections on port %u
Realmlist (Realm Id: 3) configured in port 28085
VMAPs status: Enabled. LineOfSight: true, getHeight: true, indoorCheck: true
MMAPs status: Enabled
maps directory located in /azerothcore/env/dist/data/maps. Total size: 291014951 bytes
vmaps directory located in /azerothcore/env/dist/data/vmaps. Total size: 658130721 bytes
mmaps directory located in /azerothcore/env/dist/data/mmaps. Total size: 2192910844 bytes
Default DBC locale: zhCN.
All available DBC locales: zhCN
Using World DB: ACDB 335.12-dev
Latest LoginDatabase update: 2024_01_20_00.sql
Latest CharacterDatabase update: zone_difficulty_char_tables.sql
Latest WorldDatabase update: zone_difficulty_spelloverrides.sql
LoginDatabase queue size: 0
CharacterDatabase queue size: 0
WorldDatabase queue size: 0
List of enabled modules:
|- mod-ah-bot
|- mod-anticheat
|- mod-autobalance
|- mod-eluna
|- mod-learn-spells
|- mod-skip-dk-starting-area
|- mod-solo-lfg
|- mod-zone-difficulty

Operating system

win10 wsl

Custom changes or Modules

No response

@pagimu
Copy link

pagimu commented Aug 7, 2024

I can confirm that problem.

@LiteWesteros
Copy link

Same issue on my end, whenever I enter an instance or use the ".ab mapstat" command :
image
image

FingerKnoten added a commit to FingerKnoten/mod-autobalance that referenced this issue Sep 10, 2024
Fixes the issue that variables are not properly replaced.
Instead placeholders %s,%u and %i were shown in chat.

Closes issue azerothcore#187
FingerKnoten added a commit to FingerKnoten/mod-autobalance that referenced this issue Sep 10, 2024
Fixes the issue that variables are not properly replaced.
Instead placeholders %.2f and %.3f were shown in chat.

Closes issue azerothcore#187
FingerKnoten added a commit to FingerKnoten/mod-autobalance that referenced this issue Sep 10, 2024
Makes sure the original formatting for float
placeholders still fits

Closes issue azerothcore#187
Nyeriah pushed a commit that referenced this issue Sep 10, 2024
* Fix(Core/Misc): Acore::StringFormat to fmt format

Fixes the issue that variables are not properly replaced.
Instead placeholders %s,%u and %i were shown in chat.

Closes issue #187

* Fix(Core/Misc): Acore::StringFormat to fmt format

Fixes the issue that variables are not properly replaced.
Instead placeholders %.2f and %.3f were shown in chat.

Closes issue #187

* Adjusted format for float placehodlers

Makes sure the original formatting for float
placeholders still fits

Closes issue #187
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants