diff --git a/README.md b/README.md index e6e16d5..c3d143a 100644 --- a/README.md +++ b/README.md @@ -61,6 +61,8 @@ Download the [Repository](https://github.com/ayushsharma82/AsyncElegantOTA/archi If you would like to add login to your OTA webpage, then please replace `AsyncElegantOTA.begin(&server);` with `AsyncElegantOTA.begin(&server, "username", "password");`. This will prevent unauthorized requests to your OTA webpage and prevent unauthorized firmware upload to your MCU. + If you want to disable the HTML rendering (either for security purpose or to reduce the memory space used), you can add the build flag `NOHTMLRENDER` during the build. +
Antivirus Issue: If you have an antivirus on your PC with internet security, the progress bar on webpage will instantly show 100% because of request caching by your antivirus software. There is no fix for this unless you want to disable your antivirus or whitelist your local IP addresses in it. ( Same is the case with iOS, safari will cache the outgoing requests ) diff --git a/src/AsyncElegantOTA.cpp b/src/AsyncElegantOTA.cpp index 2366906..4bd2be8 100644 --- a/src/AsyncElegantOTA.cpp +++ b/src/AsyncElegantOTA.cpp @@ -31,7 +31,7 @@ void AsyncElegantOtaClass::begin(AsyncWebServer *server, const char* username, c request->send(200, "application/json", "{\"id\": \""+_id+"\", \"hardware\": \"ESP32\"}"); #endif }); - + #ifndef NOHTMLRENDER _server->on("/update", HTTP_GET, [&](AsyncWebServerRequest *request){ if(_authRequired){ if(!request->authenticate(_username.c_str(), _password.c_str())){ @@ -42,7 +42,7 @@ void AsyncElegantOtaClass::begin(AsyncWebServer *server, const char* username, c response->addHeader("Content-Encoding", "gzip"); request->send(response); }); - + #endif _server->on("/update", HTTP_POST, [&](AsyncWebServerRequest *request) { if(_authRequired){ if(!request->authenticate(_username.c_str(), _password.c_str())){ diff --git a/src/AsyncElegantOTA.h b/src/AsyncElegantOTA.h index 326ff5d..a4ea56b 100644 --- a/src/AsyncElegantOTA.h +++ b/src/AsyncElegantOTA.h @@ -23,7 +23,9 @@ #include "ESPAsyncWebServer.h" #include "FS.h" +#ifndef NOHTMLRENDER #include "elegantWebpage.h" +#endif class AsyncElegantOtaClass{