Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduced new query parameter for jsonKey #55

Open
jfisheratwork opened this issue Jan 7, 2025 · 0 comments
Open

Introduced new query parameter for jsonKey #55

jfisheratwork opened this issue Jan 7, 2025 · 0 comments
Labels
enhancement New feature or request

Comments

@jfisheratwork
Copy link

jfisheratwork commented Jan 7, 2025

Often you are only looking for a specific key out of the secret payload. Having each consumer of the agent have to do additional work to parse json and retrieve is error prone.

Look to add parity similar to how it works when retrieving directly from ECS/task definition

Implementation details/concerns:

  • As the payload would change should it be a different end point or just an additional query param?
  • What type of validation and error codes would be needed for when json key is not present?

I am open to trying to help contribute if issue is excepted

@jfisheratwork jfisheratwork added the enhancement New feature or request label Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant