FullJitterBackoffStrategy has the wrong argument checks

[liammoyn]

Describe the bug

FullJitterBackoffStrategy takes a base delay and a max delay, the constructor checks if these values are >= 0. This check should actually be > 0 though because passing a 0 for either of these values will result in calling random.nextInt(0) on line 65, throwing an illegal argument exception when calculating the retry delay.

Expected Behavior

The retry strategy throws an exception when creating the strategy.

Current Behavior

The constructor passes and then an IllegalArgumentException is thrown on retry.

Reproduction Steps

Pass 0 for base delay or max delay parameters, have the client retry.

Possible Solution

Change the checks in the constructor from isNotNegative to isPositive

Additional Information/Context

No response

AWS Java SDK version used

2.0

JDK version used

17

Operating System and version

macOS 17.1.1

[debora-ito]

I can repro the IllegalArgumentException, although it's a weird use case to set zero to both base and max delays.

We'll fix the checks.

[github-actions]

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

[debora-ito]

@liammoyn the fix was released as part of version 2.23.1, let us know if see issues after the fix.