smithy-go data race in latest release of aws-sdk-go-v2

[abraithwaite]

Acknowledgements

• I have searched (https://github.com/aws/aws-sdk/issues?q=is%3Aissue) for past instances of this issue
• I have verified all of my SDK modules are up-to-date (you can perform a bulk update with go get -u github.com/aws/aws-sdk-go-v2/...)

Describe the bug

This bug in a dependency is present in the latest release, and triggers with the race detector on:

aws/smithy-go#548

Regression Issue

• Select this option if this issue appears to be a regression.

Expected Behavior

I expect no race to happen in the library or it's dependencies.

Current Behavior

When running code with the race detector enabled, it trips and triggers the race.

Reproduction Steps

	cfg, err := config.LoadDefaultConfig(context.TODO())
	if err != nil {
		return err
	}
	s3client := s3.NewFromConfig(cfg)
	uploader := manager.NewUploader(s3client, func(u *manager.Uploader) {
		u.Concurrency = 5
		u.LeavePartsOnError = false
	})

	_, err := uploader.Upload(ctx, &s3.PutObjectInput{
		Bucket: aws.String(bucket),
		Key:    aws.String(key),
		Body:   in.Data,
	})
	return err

Possible Solution

No response

Additional Information/Context

No response

AWS Go SDK V2 Module Versions Used

$ grep 'aws-sdk-go-v2' go.mod
        github.com/aws/aws-sdk-go-v2 v1.32.5
        github.com/aws/aws-sdk-go-v2/config v1.28.5
        github.com/aws/aws-sdk-go-v2/credentials v1.17.46
        github.com/aws/aws-sdk-go-v2/feature/s3/manager v1.17.39
        github.com/aws/aws-sdk-go-v2/service/s3 v1.67.1
        github.com/aws/aws-sdk-go-v2/service/sts v1.33.1
        github.com/aws/aws-sdk-go-v2/aws/protocol/eventstream v1.6.7 // indirect
        github.com/aws/aws-sdk-go-v2/feature/ec2/imds v1.16.20 // indirect
        github.com/aws/aws-sdk-go-v2/internal/configsources v1.3.24 // indirect
        github.com/aws/aws-sdk-go-v2/internal/endpoints/v2 v2.6.24 // indirect
        github.com/aws/aws-sdk-go-v2/internal/ini v1.8.1 // indirect
        github.com/aws/aws-sdk-go-v2/internal/v4a v1.3.24 // indirect
        github.com/aws/aws-sdk-go-v2/service/internal/accept-encoding v1.12.1 // indirect
        github.com/aws/aws-sdk-go-v2/service/internal/checksum v1.4.5 // indirect
        github.com/aws/aws-sdk-go-v2/service/internal/presigned-url v1.12.5 // indirect
        github.com/aws/aws-sdk-go-v2/service/internal/s3shared v1.18.5 // indirect
        github.com/aws/aws-sdk-go-v2/service/sso v1.24.6 // indirect
        github.com/aws/aws-sdk-go-v2/service/ssooidc v1.28.5 // indirect

Compiler and Version used

go version go1.23.3 darwin/arm64

Operating System and version

Darwin root.us-west-2.local 23.6.0 Darwin Kernel Version 23.6.0: Thu Sep 12 23:36:12 PDT 2024; root:xnu-10063.141.1.701.1~1/RELEASE_ARM64_T6020 arm64

[github-actions]

This issue is now closed. Comments on closed issues are hard for our team to see.
If you need more assistance, please open a new issue that references this one.

[github-actions]

This issue is now closed. Comments on closed issues are hard for our team to see.
If you need more assistance, please open a new issue that references this one.