Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Memory leaks on web sockets: each DataStore.start() add new web sockets but old ones remain active. use Starscream 4.0.6 #3509

Closed
lawmicha opened this issue Feb 9, 2024 · 5 comments
Labels
bug Something isn't working datastore Issues related to the DataStore category

Comments

@lawmicha
Copy link
Contributor

lawmicha commented Feb 9, 2024

During this test I can see that there are memory leaks on web sockets: each DataStore.start() add new web sockets but old ones remain active. In my mind, we should use Starscream 4.0.6 which include this fix: daltoniam/Starscream@d2a9549

Originally posted by @gbitaudeau in #3259 (comment)

Copy link
Contributor

github-actions bot commented Feb 9, 2024

This issue was opened by a maintainer of this repository; updates will be posted here. If you are also experiencing this issue, please comment here with any relevant information so that we're aware and can prioritize accordingly.

@lawmicha lawmicha added bug Something isn't working datastore Issues related to the DataStore category labels Feb 9, 2024
@lawmicha
Copy link
Contributor Author

lawmicha commented Mar 1, 2024

We're in the process of migrating off AppSyncRealTimeClient package, which has the dependency on Starscream, over to URLSession here #3527 We should retest the memory leak scenario the changes from this PR

@lawmicha
Copy link
Contributor Author

lawmicha commented Apr 5, 2024

We plan to upgrade Starscream to 4.0.7. We can merge the upgrade commit on top of main and release it as 3.2.0 https://github.com/aws-amplify/aws-appsync-realtime-client-ios/commits/main/ . The upgrade 4.0.6 will be replaced, we will not have a release which depends on 4.0.6

Image

@lawmicha
Copy link
Contributor Author

lawmicha commented Apr 9, 2024

Amplify V2 (main branch) no longer depends on AppSyncRealTimeClient package which had Starscream, it was replaced at v2.29.0 https://github.com/aws-amplify/amplify-swift/releases/tag/2.29.0

@lawmicha lawmicha closed this as completed Apr 9, 2024
Copy link
Contributor

github-actions bot commented Apr 9, 2024

This issue is now closed. Comments on closed issues are hard for our team to see.
If you need more assistance, please open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working datastore Issues related to the DataStore category
Projects
None yet
Development

No branches or pull requests

1 participant