Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter automatic Github PR previews based on labels, name, files modified #3960

Open
3 tasks done
taraspos opened this issue Oct 23, 2024 · 2 comments
Open
3 tasks done
Labels
feature-request New feature or request

Comments

@taraspos
Copy link

Before opening, please confirm:

Amplify Hosting feature

Git providers, Web previews

Is your feature request related to a problem? Please describe:

Amplify currently allows configuration of automatic PR previews for the GitHub provider. However, all pull requests targeting the configured branch are discovered automatically. We would like the ability to filter which PRs trigger automatic previews based on:

This feature is critical, especially considering the hard limit of 50 open branches per app1.

We are using Amplify to generate Pull Request previews for documentation pages stored alongside the code in a large GitHub repository. Only certain Pull Requests modify documentation files. However, every Pull Request is automatically discovered, which brings us close to the limit of open branches and wastes build minutes.

Describe how you'd like this feature to work

Currently Amplify has a setting AutoBranchCreationPatterns that can be used to limit number of automatically discovered branches, however no such setting for Pull Request discovery2.

Pull Request discovery should have similar configuration, where they can be filtered based on the PR name or labels. Having ability to discover PRs based on modified files will be immensely useful as well (similar to #2336)

Footnotes

  1. https://docs.aws.amazon.com/amplify/latest/userguide/quotas-chapter.html

  2. https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-resource-amplify-branch.html#cfn-amplify-branch-enablepullrequestpreview

@taraspos taraspos added the feature-request New feature or request label Oct 23, 2024
Copy link

This has been identified as a feature request. If this feature is important to you, we strongly encourage you to give a 👍 reaction on the request. This helps us prioritize new features most important to you. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant