-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Skipped builds fail #3268
Comments
Hi @jdpst 👋🏽 thanks for raising this issue. We are currently working on reproducing and root causing this issue. Will update once we have next steps. |
@hloriana any updates? |
Now available as a beta, Amplify Hosting has improved support for monorepo frameworks including |
Any updates on this? Having the same problem with a turborepo setup.
|
@michrome
|
We are also running into the very same issue. We have Nuxt 3 apps in Turborepo. Our version: 1
applications:
- appRoot: apps/appOne
frontend:
buildPath: /
phases:
preBuild:
commands:
- npm install -g pnpm
- nvm use 18 && node --version
- corepack enable && npx --yes nypm install
build:
commands:
- pnpm build:appOne
artifacts:
baseDirectory: .amplify-hosting
files:
- "**/*"
- appRoot: apps/appTwo
frontend:
buildPath: /
phases:
preBuild:
commands:
- npm install -g pnpm
- nvm use 18 && node --version
- corepack enable && npx --yes nypm install
build:
commands:
- pnpm build:appTwo
artifacts:
baseDirectory: .amplify-hosting
files:
- "**/*" And then for each app in the Amplify dashboard, we set the environment variables to: Deployment works fine without Here are the logs
Technically it's working, as it's not building, but having the Amplify dashboard report failed deployments seems wrong. |
@Namstel We pushed an update last week to fix this issue. |
This issue is now closed. Comments on closed issues are hard for our team to see. |
This issue has been automatically locked. |
Before opening, please confirm:
App Id
d1zloo668ozrvr
AWS Region
eu-west-1
Amplify Hosting feature
Frontend builds, Monorepo
Describe the bug
Diff deployment correctly detects when there are no changes and skips running the build, but then fails because it complains that the build artefact doesn't exist. See logs and buildspec below.
Expected behavior
When a build is supposed to be skipped I would expect it to actually be skipped, not to fail.
Reproduction steps
Build Settings
Log output
Additional information
We use the GitHub App integration with a monorepo so builds are frequently skipped. However, when they are skipped it causes the checks on a PR to fail, which is annoying. This also means we can't distinguish between actual failures and "skips" without signing in to the AWS console and checking the build logs. Very annoying.
The text was updated successfully, but these errors were encountered: