Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deleting back-end environment just deleted all our S3 data?! #2384

Closed
4 tasks done
jamescrowley opened this issue Nov 16, 2021 · 4 comments
Closed
4 tasks done

Deleting back-end environment just deleted all our S3 data?! #2384

jamescrowley opened this issue Nov 16, 2021 · 4 comments
Labels
archived This issue has been locked. UX

Comments

@jamescrowley
Copy link

jamescrowley commented Nov 16, 2021

Before opening, please confirm:

App Id

d3dw5sp1sablwh

Region

eu-west-1

Amplify Console feature

Backend builds

Describe the bug

Deleting our back-end deleted the storage S3 bucket (along with all its contents), despite the fact the cloudformation retention policy was set to retain.

		"DeletionPolicy" : "Retain",

(I double checked before triggering the delete from amplify).

We tested deleting the dev environment, but due to #2369 we had to delete manually from cloud formation, which worked as expected and retained the S3 bucket and it's data.

When deleting the production environment, the CloudFormation log clearly shows it being retained as expected

Screenshot 2021-11-16 at 16 48 03

and yet somehow subsequently Amplify deletes it later in the process when deleting from the console?

Expected behavior

You should not delete data in S3 storage buckets without warning! What am I missing here? This seems a completely insane default behaviour without some kind of UI warning or confirmation or option.

Reproduction steps

  1. Create back-end environment configured with storage
  2. Store data in storage
  3. Delete back-end environment

Build Settings

No response

Additional information

No response

@github-actions
Copy link

Hi 👋, thanks for opening! While we look into this...

If this issue is related to custom domains, be sure to check the custom domains troubleshooting guide to see if that helps. Also, there is a more general troubleshooting FAQ that may be helpful for other questions.

Lastly, please make sure you've specified the App ID and Region in the issue!

@jamescrowley jamescrowley changed the title Deleting back-end environment just deleted all our S3 data?!!!! Deleting back-end environment just deleted all our S3 data?! Nov 16, 2021
@ghost
Copy link

ghost commented Nov 18, 2021

Hi @jamescrowley 👋🏽 thank you for raising this issue. We are treating this as a priority and are currently investigating this behavior. We will provide an update as soon as possible.

@ghost
Copy link

ghost commented Nov 18, 2021

@jamescrowley This is default behavior when deleting backend environments. Buckets are generated with the "DeletionPolicy" : "Retain" policy so that they aren't deleted when running CLI commands like amplify remove. However, deleting your backend will remove all resources associated with that project.

We appreciate your feedback and will update our UI to include a clear warning to emphasize this behavior.

@abhi7cr abhi7cr added the UX label Nov 18, 2021
@ghost ghost closed this as completed Nov 19, 2021
@github-actions
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot added the archived This issue has been locked. label Oct 28, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Oct 28, 2022
This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
archived This issue has been locked. UX
Projects
None yet
Development

No branches or pull requests

2 participants