-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for path custom type conversion #539
Comments
Can we get more concrete examples of the types for this use case rather than Foo? I presume these are DDD types but let's get some good understanding of the motivation. There is some interaction with the logic that determines what parameter is used for the body content. This is probably the main concern here - that we don't suffer in terms of handling the body parameter. This is somewhat because as avaje-http uses annotation processing we actually know the method parameter names and as such we then don't need explicit annotations for path parameters and query parameters ... and this then impacts the determination of which parameter is for the body. Rightly or wrongly, we have the |
this is simple to handle, this should only apply if it's a GET/DELETE HTTP verb, or if the parameter is explicitly annotated with @QueryParam/@Header/Other |
I'm indifferent, but since we're jumping major versions to 3.0 you have the opportunity to change it. |
We still need this. The description uses Foo which does not actually express the motivation. In addition the discord example is not valid as it uses Ideally we get the description of this issue updated so that we clearly understand the motivation and use case. Edit: My guess is that this is desired to support both query parameters and path parameters, it would be good to clarify exactly what this feature request is for. |
From the discord:
I'm thinking we could make it so that:
could generate something like:
Where
asType
would be a new method added that takes a reference to a constructor/valueOf methodThe text was updated successfully, but these errors were encountered: