New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

should fxID serialization be skipped? #173

Open

deian opened this issue Mar 14, 2024 · 1 comment

deian commented Mar 14, 2024

From my understanding (and comment)fxIDshould not be (de)serialized here:

avalanche-rs/crates/avalanche-types/src/txs/transferable.rs

Lines 389 to 393 in 58f3ed6

    
           pub asset_id: ids::Id, 
        
           #[serde(rename = "fxID")] 
        
           pub fx_id: ids::Id, // skip serialization due to serialize:"false"

The text was updated successfully, but these errors were encountered:

Contributor

gyuho commented Mar 16, 2024

Yes, correct.

We follow

https://github.com/ava-labs/avalanchego/blob/b62846fa8f09e85e8e4cfe49825c301d20124f84/vms/avm/fxs/fx.go#L61-L62

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment