Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Masks: refactor #418

Open
7 of 15 tasks
aurelienpierre opened this issue Jan 19, 2025 · 3 comments
Open
7 of 15 tasks

Masks: refactor #418

aurelienpierre opened this issue Jan 19, 2025 · 3 comments
Assignees
Milestone

Comments

@aurelienpierre
Copy link
Collaborator

aurelienpierre commented Jan 19, 2025

  • move dt_dev_add_history_item() calls outside of drawing functions 87bf061
  • move direct UI calls to redraw outside of drawing functions d6ca2bc
  • remove redundant pipe invalidations from drawing functions d2f681d
  • add a GUI timeout on mask user events to prevent continuously commiting to history d115abf
  • manage an high-level forms hash to detect changes on drawn shapes and commit on history only when needed 55f5596
  • detach getter/setter functions for masks properties (size, opacity, hardness) from direct GUI events handlers
  • expose mask locking mode on darkroom zooming & panning in GUI checkbox
  • add opacity mask slider in GUI
  • add hardness mask slider in GUI
  • add rescaling mask slider in GUI
  • add combobox for mapping Wacom pen pressure to mask properties in GUI
  • add shapes creation toggle buttons to darkroom toolbar
  • make continuous drawing by default until disabled from shapes creation toogle buttons
  • make contextual menu on right clic on shapes, allowing to delete shape and add/delete nodes from there
  • ensure no keyboard shortcuts are required for typical mask drawing, aka WE CAN FUCKING DRAW MASKS WITH ONLY A WACOM TABLET IN A PHOTO EDITOR IN 2025
@Jiyone
Copy link
Collaborator

Jiyone commented Jan 19, 2025

aka WE CAN FUCKING DRAW MASKS WITH ONLY A WACOM TABLET IN A PHOTO EDITOR IN 2025

yay

@Jiyone
Copy link
Collaborator

Jiyone commented Jan 19, 2025

make contextual menu on right clic on shapes, allowing to delete shape and add/delete nodes from there

Could be a good idea to put the boolean operation in that menu.

@lukadh
Copy link
Collaborator

lukadh commented Jan 19, 2025

make contextual menu on right clic on shapes, allowing to delete shape and add/delete nodes from there

I was thinking about that just yesterday! Nice!

add shapes creation toggle buttons to darkroom toolbar

About this one. Would it be sensible to have on central "Mask control module" instead of having it in every module?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: In Progress
Development

No branches or pull requests

3 participants