Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Problem: data.json is a generated file but included in source control #4

Open
1082008 opened this issue Apr 28, 2017 · 0 comments
Open

Problem: data.json is a generated file but included in source control #4

1082008 opened this issue Apr 28, 2017 · 0 comments

Comments

@1082008
Copy link

1082008 commented Apr 28, 2017

Source control is for source files. data.json is not a source file so it should not be under source control, it should not be commited.

To make data.json available despite not being present in the repository, it should be handled as a build artifact. Build artifacts can be downloaded from github releases. This move needs a working travis CI configuration. I plan to create a PR for that.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@1082008