Make probing async

[devongovett]

Basically, allow reading more data than just the first chunk we received. This is especially important for MP3, and in Node.js where the default chunk size is smaller.

See audiocogs/mp3.js#12

[fabslab]

👍 seems like this has been the cause of a lot of streaming related issues aurora has received

[Pheo-Player]

Definitely the source of some headaches, and it'd be great to see this 'fixed'.

However, I can't think of a way that this would not be a breaking change to users. Do we want probe to return a promise? Then we'd probably need all API logic to return promises as well. While in my opinion that'd be actually a great thing to have, it's a. again, a breaking change and b. probably a lot of work. I'll be glad to help after trying to read into the source code some more.

[devongovett]

I don't think the API would need to change at all, it would work just like the decoders do when there isn't enough data. When trying to read from a stream and there isn't enough data, an UnderflowError is thrown. This can be caught by the framework and the probing request can be retried when more data is available.

[Pheo-Player]

Makes sense! Is this commit 7e59806 related to this?

[devongovett]

Kinda. I was going to mention that. That commit ignores errors while probing and goes to the next format instead of erroring completely.

[allphat]

Quick question : This should fix the no sound on small mp3 files ?
I m trying to read some relatively small mp3s (approx. 60s) but no sound and no errors too.