Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ETAs #16

Open
athuler opened this issue Jul 23, 2024 · 3 comments · Fixed by #25
Open

ETAs #16

athuler opened this issue Jul 23, 2024 · 3 comments · Fixed by #25
Labels
enhancement New feature or request
Milestone

Comments

@athuler
Copy link
Owner

athuler commented Jul 23, 2024

Allow for the querying of estimated arrival times

@athuler athuler converted this from a draft issue Jul 23, 2024
@athuler athuler added the enhancement New feature or request label Jul 23, 2024
@athuler athuler added this to the 0.3.0 milestone Aug 19, 2024
@athuler athuler moved this from Todo to In Progress in Passio Go Aug 19, 2024
@dmv1167
Copy link

dmv1167 commented Sep 28, 2024

You may be interested in this collection of repos, specifically this repo. Perhaps you could pull from their API that has done the heavy lifting or poke around to see how they get their information. I appreciate having your library in python so the ladder may be more appealing, I'll look into it as well.

#25 I worked with that API to get some basic ETA's working

@athuler
Copy link
Owner Author

athuler commented Sep 29, 2024

I've seen these repos around and they are amazing! I might add them to the readme as an additional resource for people who may be interested!

For the ETA, I would like to stay with the native PassioGo API. The native ETA request structure is https://passiogo.com/mapGetData.php?eta=3&deviceId=59804559&stopIds=cta1514. (Sorry for not including it in the issue in the first place!) It seems that it's not as straightforward as the other requests, but it seems parseable.

And thanks for your PR! I'll take a look at your work!

@athuler athuler linked a pull request Oct 1, 2024 that will close this issue
@dmv1167
Copy link

dmv1167 commented Oct 1, 2024

I just realized that I incorrectly claimed that the min() operation performed in Stop.getNextVehicle() would operate in O(1) time complexity. In reality, that method could simply return Stop.getEtas()[0] as PassioGo presents them in ascending order by eta, and therefore the entire method may not be required.

We may simply want to state in the docstring for Stop.getEtas() that etas are considered to be sorted upon creation.

I've opened #31 that addresses issues I missed initially.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: In Progress
Development

Successfully merging a pull request may close this issue.

2 participants