Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use @javax.annotation.processing.Generated after moving to Java 9+ #194

Closed
Zegveld opened this issue Jan 14, 2022 · 10 comments · Fixed by #239
Closed

Use @javax.annotation.processing.Generated after moving to Java 9+ #194

Zegveld opened this issue Jan 14, 2022 · 10 comments · Fixed by #239
Assignees
Milestone

Comments

@Zegveld
Copy link

Zegveld commented Jan 14, 2022

all javax modules are being replaced with jakarta, this includes @javax.annotation.Generated. This is replaced by @jakarta.annotation.Generated, allow users to choose which annotation they want on the generated classes.

(I'm also creating a PR for this.)

Zegveld added a commit to rigd-loxia/assertj-assertions-generator that referenced this issue Jan 14, 2022
…choose between javax.annotation.Generated and jakarta.annotation.Generated. Or if you really do not want any no annotation (not recommended).
Zegveld added a commit to rigd-loxia/assertj-assertions-generator that referenced this issue Jan 26, 2022
…can now choose between javax.annotation.Generated and jakarta.annotation.Generated. Or if you really do not want any no annotation (not recommended)."

This reverts commit 3d0a7eb.
Zegveld added a commit to rigd-loxia/assertj-assertions-generator that referenced this issue Jan 26, 2022
Zegveld added a commit to rigd-loxia/assertj-assertions-generator that referenced this issue Jan 26, 2022
@famaridon
Copy link

+1

@rob-valor
Copy link

@joel-costigliola , any reason why the jakarta support doesn't get merged?

@joel-costigliola
Copy link
Member

just lack of time, the generator is currently in a limbo state because of that ...

@scordio
Copy link
Member

scordio commented Jul 28, 2024

Team decision: We will start the development of the next major version with Java 17 as a baseline to better aid records and jakarta support.

@scordio scordio pinned this issue Jul 28, 2024
@reitzig
Copy link

reitzig commented Aug 2, 2024

FWIW, in JDK 21, javax.annotation.Generated is gone so the generated assertions do not compile.

Manually replacing with @javax.annotation.processing.Generated works, of course, but that's not really what we're going for, is it? 😅 We could override all templates, I guess ...

@scordio scordio self-assigned this Aug 2, 2024
@reitzig
Copy link

reitzig commented Sep 26, 2024

@scordio Any way we can help? We keep writing assertion classes and would much rather spend the time here. 😅

@scordio
Copy link
Member

scordio commented Sep 29, 2024

Hi @reitzig, I appreciate the offer! 🙂 nothing special where you could help, I'm afraid: I'm upgrading dependencies and aligning the parent POM to the latest version, which already brings a few challenges due to the custom JUnit 4 rules... once this is over, it should be possible to speed up the other topics.

I'll keep you posted.

@scordio
Copy link
Member

scordio commented Oct 9, 2024

Additional team decision: we will stick to @javax.annotation.processing.Generated.

@scordio scordio changed the title allow the jakarta version of @Generated instead of the javax one. Use @javax.annotation.processing.Generated after moving to Java 9+ Oct 9, 2024
@scordio scordio added this to the 3.0.0 milestone Oct 9, 2024
@scordio scordio unpinned this issue Oct 16, 2024
@reitzig
Copy link

reitzig commented Oct 29, 2024

I was able to force v3.0.0-M3 on v2.2.0 of the Maven plugin and can confirm: this is fixed. Thanks!

@scordio
Copy link
Member

scordio commented Oct 29, 2024

Very cool, thanks for checking!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment