Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unable to create requests #34

Closed
1 task
alishaevn opened this issue Jan 12, 2024 · 3 comments · Fixed by #35
Closed
1 task

unable to create requests #34

alishaevn opened this issue Jan 12, 2024 · 3 comments · Fixed by #35
Assignees
Labels
bug something isn't working

Comments

@alishaevn
Copy link
Member

Story

related: assaydepot/webstore#342

the initial problem with creating requests has been fixed in the webstore and for phenovista. afterwards, a new error popped up. only for pheno.

Acceptance Criteria

  • users are able to create a new request for an identified service

Screenshots / Video

image

Testing Instructions and Sample Files

  • go to "/browse"
  • click on "request this item" next to a service (which will require you to sign in if you haven't already)
  • fill out the required fields
  • press "initiate request" at the bottom right of the page
@alishaevn alishaevn self-assigned this Jan 12, 2024
@alishaevn
Copy link
Member Author

also discussing in slack.
image

@alishaevn alishaevn added the bug something isn't working label Jan 12, 2024
@alishaevn alishaevn moved this to In Development in webstore Jan 17, 2024
@alishaevn
Copy link
Member Author

alishaevn commented Jan 17, 2024

talked about this with @cpetersen in a huddle.

he thinks that requests being made at all has been an accident. when looking for a quote groups data in the rails console, it should return a hash with the data from the form. the quote groups that were made on webstore-staging, have an empty hash however. he believes if we pass the data_str and dynamic_forms_to_embed properties to https://github.com/assaydepot/scientist_api_v2/blob/ad191db7650f866797442e5fbc7b4829f181c5ce/lib/scientist_api_v2/app/controllers/scientist_api_v2/quote_groups_controller.rb#L341, we can create requests.

@alishaevn
Copy link
Member Author

continuing the above conversation in this thread.

@alishaevn alishaevn linked a pull request Jan 18, 2024 that will close this issue
@alishaevn alishaevn moved this from In Development to Code Review in webstore Jan 19, 2024
@github-project-automation github-project-automation bot moved this from Code Review to Done in webstore Jan 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant