Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Does not work with --experimental_sibling_repository_layout #285

Open
matthewjh opened this issue Nov 19, 2024 · 3 comments
Open
Labels
bug Something isn't working

Comments

@matthewjh
Copy link

matthewjh commented Nov 19, 2024

What happened?

When building an SWC output with --experimental_sibling_repository_layout, SWCCompile exits with an error:

src/main/tools/linux-sandbox-pid1.cc:548: "execvp(external/swc_linux-x64-gnu/swc-linux-x64-gnu, 0x14e1720)": No such file or directory  

Version

Development (host) and target OS/architectures:

Ubuntu 22, linux amd64

Output of bazel --version:

Version of the Aspect rules, or other relevant rules from your
WORKSPACE or MODULE.bazel file:

rules_swc 2.0.0

Language(s) and/or frameworks involved:
7.4.1

How to reproduce

No response

Any other information?

No response

@matthewjh matthewjh added the bug Something isn't working label Nov 19, 2024
@jbedard
Copy link
Member

jbedard commented Dec 4, 2024

FWIW I think almost every aspect ruleset using toolchains has this issue where we prepend external/ to the path of the binary, rules_esbuild being another example (which has the path prepended so I assume it has the bug).

@alexeagle
Copy link
Member

@matthewjh do you have any idea the severity of this issue - meaning, have you seen some indication this flag is going to be flipped and users will be broken unless we take action?
Another way to ask: what led you to try that flag?

@matthewjh
Copy link
Author

@alexeagle I hit this issue, due an external directory in our source tree:

bazelbuild/bazel#4508

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants