Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use 'installer' for unpacking wheels into the venv #33

Closed
mattem opened this issue May 30, 2022 · 1 comment
Closed

Use 'installer' for unpacking wheels into the venv #33

mattem opened this issue May 30, 2022 · 1 comment
Labels
enhancement New feature or request

Comments

@mattem
Copy link
Collaborator

mattem commented May 30, 2022

Currently we assume there's a pip installed in the same bin directory as python, and we assume the version is compatible with the flags passed. If using the hermetic toolchains from rules_python this is generally okay, however if using a different toolchain or that of the host, then we can not guarantee the presence of pip where we expect it.

An alternative would be to use https://github.com/pypa/installer directly and not have pip involved.

Another alternative would be to not to use either for actions, and have bazel layout the venv using the runfiles symlinks.

@mattem mattem changed the title Use 'installer Use 'installer' for unpacking wheels into the venv May 30, 2022
@mattem mattem moved this to 📋 Backlog in Open Source Feb 14, 2023
@mattem mattem added the enhancement New feature or request label Feb 14, 2023
@mattem
Copy link
Collaborator Author

mattem commented Mar 23, 2024

Closed via #233

@mattem mattem closed this as completed Mar 23, 2024
@github-project-automation github-project-automation bot moved this from 📋 Backlog to ✅ Done in Open Source Mar 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
No open projects
Status: Done
Development

No branches or pull requests

1 participant