From a55e47965f15787a679b1e0c8b2314b8c43c9b22 Mon Sep 17 00:00:00 2001 From: Tina Mueller Date: Tue, 31 Mar 2020 12:12:17 +0200 Subject: [PATCH] Remove perlcritic policy ConsistentQuoteLikeWords It's not used anyway. See also https://github.com/os-autoinst/os-autoinst/pull/1375 --- .perlcriticrc | 3 -- .../Critic/Policy/ConsistentQuoteLikeWords.pm | 35 ------------------- 2 files changed, 38 deletions(-) delete mode 100755 lib/perlcritic/Perl/Critic/Policy/ConsistentQuoteLikeWords.pm diff --git a/.perlcriticrc b/.perlcriticrc index 7fdede84544..e6dd3ae5b4e 100644 --- a/.perlcriticrc +++ b/.perlcriticrc @@ -7,6 +7,3 @@ severity = 3 [Perl::Critic::Policy::HashKeyQuotes] severity = 5 - -[Perl::Critic::Policy::ConsistentQuoteLikeWords] -severity = 5 diff --git a/lib/perlcritic/Perl/Critic/Policy/ConsistentQuoteLikeWords.pm b/lib/perlcritic/Perl/Critic/Policy/ConsistentQuoteLikeWords.pm deleted file mode 100755 index b1372891ddc..00000000000 --- a/lib/perlcritic/Perl/Critic/Policy/ConsistentQuoteLikeWords.pm +++ /dev/null @@ -1,35 +0,0 @@ -package Perl::Critic::Policy::ConsistentQuoteLikeWords; - -use strict; -use warnings; - -use base 'Perl::Critic::Policy'; - -use Perl::Critic::Utils qw( :severities :classification :ppi ); - -our $VERSION = '0.0.1'; - -sub default_severity { return $SEVERITY_HIGH } -sub default_themes { return qw(openqa) } -sub applies_to { return qw(PPI::Token::QuoteLike::Words) } - -# check that qw is used as function and only for multiple values -# (os-autoinst coding style) - -sub violates { - my ($self, $elem) = @_; - - my $desc = q{qw should be used as function}; - my $expl = q{use qw(A B)}; - - if ($elem =~ m/^\Qqw(\E/) { - return unless $elem->parent->isa('PPI::Statement::Include'); - # ok if there is whitespace too - return unless $elem =~ /^qw\(\s*\S+\s*\)$/; - return unless $elem->parent->isa('PPI::Statement::Include'); - $expl = q{use MODULE 'func' for single imports}; - } - return $self->violation($desc, $expl, $elem); -} - -1;