Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

validate_datatype raises instead of yield preventing some schema combiner usage #1903

Open
braingram opened this issue Feb 12, 2025 · 0 comments · May be fixed by #1904
Open

validate_datatype raises instead of yield preventing some schema combiner usage #1903

braingram opened this issue Feb 12, 2025 · 0 comments · May be fixed by #1904

Comments

@braingram
Copy link
Contributor

The use of raise (for example):

asdf/asdf/tags/core/ndarray.py

Line 529 in 9d7ff2e

raise ValidationError(msg)

in validate_datatype can lead to incorrect validation errors when used within a schema combiner. A schema containing:

anyOf:
  - tag: tag:stsci.edu:asdf/core/ndarray-1.*
    datatype: float64
  - "null"

Fails for None values with ValidationError: Not an array.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Datatype validator fix braingram/asdf
1 participant
@braingram