From 74cd1b34e0fac0b0e3be4e5e36b11f6a2cac8989 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Patrick=20Abrah=C3=A3o?= <patrick@ivex.ai>
Date: Mon, 8 Jul 2024 10:58:25 +0200
Subject: [PATCH] Remove file type from result file location (#14)

Signed-off-by: patrickpa <patrick@ivex.ai>
---
 README.md                          | 1 -
 qc_baselib/models/result.py        | 1 -
 qc_baselib/result.py               | 2 --
 tests/data/result_test_output.xqar | 2 +-
 tests/test_result.py               | 2 --
 5 files changed, 1 insertion(+), 7 deletions(-)

diff --git a/README.md b/README.md
index b6f2629..213a645 100644
--- a/README.md
+++ b/README.md
@@ -216,7 +216,6 @@ def main():
         issue_id=issue_id,
         row=1,
         column=0,
-        file_type="odr",
         description="Location for issue",
     )
 
diff --git a/qc_baselib/models/result.py b/qc_baselib/models/result.py
index 85ab59f..da6877d 100644
--- a/qc_baselib/models/result.py
+++ b/qc_baselib/models/result.py
@@ -31,7 +31,6 @@ class InertialLocationType(BaseXmlModel):
 class FileLocationType(BaseXmlModel):
     column: int = attr(name="column")
     row: int = attr(name="row")
-    file_type: str = attr(name="fileType")
 
 
 class LocationType(BaseXmlModel):
diff --git a/qc_baselib/result.py b/qc_baselib/result.py
index 142d0ac..c456934 100644
--- a/qc_baselib/result.py
+++ b/qc_baselib/result.py
@@ -259,13 +259,11 @@ def add_file_location(
         issue_id: int,
         row: int,
         column: int,
-        file_type: str,
         description: str,
     ) -> None:
         file_location = result.FileLocationType(
             row=row,
             column=column,
-            file_type=file_type,
         )
 
         bundle = self._get_checker_bundle(checker_bundle_name=checker_bundle_name)
diff --git a/tests/data/result_test_output.xqar b/tests/data/result_test_output.xqar
index 9e89f1c..c52c23f 100644
--- a/tests/data/result_test_output.xqar
+++ b/tests/data/result_test_output.xqar
@@ -5,7 +5,7 @@
       <AddressedRule ruleUID="test.com:qc:1.0.0:qwerty.qwerty"/>
       <Issue issueId="0" description="Issue found at odr" level="3" ruleUID="test.com:qc:1.0.0:qwerty.qwerty">
         <Locations description="Location for issue">
-          <FileLocation column="0" row="1" fileType="odr"/>
+          <FileLocation column="0" row="1"/>
         </Locations>
         <Locations description="Location for issue">
           <XMLLocation xpath="/foo/test/path"/>
diff --git a/tests/test_result.py b/tests/test_result.py
index 985dcb4..32478f6 100644
--- a/tests/test_result.py
+++ b/tests/test_result.py
@@ -79,7 +79,6 @@ def test_result_write() -> None:
         issue_id=issue_id,
         row=1,
         column=0,
-        file_type="odr",
         description="Location for issue",
     )
     result.add_xml_location(
@@ -439,7 +438,6 @@ def test_domain_specific_info_add():
         issue_id=issue_id,
         row=1,
         column=0,
-        file_type="odr",
         description="Location for issue",
     )