Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wrong heading structure in geometry chapter #314

Merged
merged 8 commits into from
Jan 23, 2025
Merged

Conversation

martinfiebig
Copy link
Collaborator

@martinfiebig martinfiebig commented Jan 22, 2025

Describe your changes

This pull request fixes the wrong heading structure described in #315

Issue ticket number and link

#315

Checklist before requesting a review

  • I have performed a self-review of my code/documentation.
  • My changes generate no new warnings during the documentation generation.

Signed-off-by: Martin Fiebig <[email protected]>
Signed-off-by: Martin Fiebig <[email protected]>
Signed-off-by: Martin Fiebig <[email protected]>
Signed-off-by: Martin Fiebig <[email protected]>
@martinfiebig martinfiebig changed the title WIP - test different structure Fix wrong heading structure in geometry chapter Jan 22, 2025
@martinfiebig martinfiebig marked this pull request as ready for review January 22, 2025 10:48
@ClemensLinnhoff
Copy link
Collaborator

I would remove the 7.3 page, as written here: #315 (comment)

Signed-off-by: Martin Fiebig <[email protected]>
@martinfiebig
Copy link
Collaborator Author

Hi @ClemensLinnhoff, I've removed the 7.3 page now.

@ClemensLinnhoff
Copy link
Collaborator

Hi @ClemensLinnhoff, I've removed the 7.3 page now.

Thanks, but now this link does not work anymore. I am not sure if there are more links to this page in the documentation, that need to be fixed:
https://github.com/asam-ev/OpenMATERIAL/blob/main/content/geometry/general.adoc?plain=1#L106

Signed-off-by: Martin Fiebig <[email protected]>
@martinfiebig
Copy link
Collaborator Author

martinfiebig commented Jan 23, 2025

Thanks, but now this link does not work anymore. I am not sure if there are more links to this page in the documentation, that need to be fixed: https://github.com/asam-ev/OpenMATERIAL/blob/main/content/geometry/general.adoc?plain=1#L106

Hi Clemens, I just went through the documentation and fixed the link wherever it was broken.

@ClemensLinnhoff ClemensLinnhoff merged commit e9e3f0d into main Jan 23, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants