Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When public users create a MyGiza Collection, it should be private by default, not viewable by everyone. @lukehollis #157

Open
lukehollis opened this issue Mar 31, 2021 · 6 comments

Comments

@lukehollis
Copy link
Contributor

When public users create a MyGiza Collection, it should be private by default, not viewable by everyone. @lukehollis

Originally posted by @npicardo in #151 (comment)

@lukehollis lukehollis self-assigned this Mar 31, 2021
@lukehollis
Copy link
Contributor Author

For this issue, if it seems correct, I'll add a new Boolean field to the Collection model called public that can be toggled by a user in the Public group while managing their Collection. There isn't a place for managing this field as a Public user in the templates currently, so I'll add one near the Collection title unless anyone has another place that they'd like this field to go.

@npicardo
Copy link
Collaborator

@lukehollis A toggle for Collection owners to make a Collection public/private is great!
A practical question: If we get a lot of users, would it make sense to only allow Admins to have public Collections? If any public user can make Collections public, could we be setting ourselves up for an impractically large number for browsing on the front end? Meaning, should we opt to make just the Project-curated Collections public? Or just go to town now and cross that bridge when we come to it later?

@rsinghal
Copy link
Contributor

rsinghal commented Apr 1, 2021

It's a lot harder to go from anyone can make things public to just admins than the reverse. Also, if another user is relying on a public collection made by another user and then that user makes it private, that could confuse users. I think the ramifications of implementing this needs to be thought through. My suggested would be to make non-admin collections private and Admin collections public.

@npicardo
Copy link
Collaborator

npicardo commented Apr 1, 2021

Thanks, Rashmi, that gets to the heart of my question.
Let's please do go with only Admins with public/private toggle, with Public users only able to create private Collections.
@lukehollis

(Maybe someday off in the future we'll be able to consider an update to MyGiza by which Collections themselves can be organized, sorted, searched, as a way of allowing user-generated public Collections that's manageable. Definitely for another day...)

@lukehollis
Copy link
Contributor Author

Sounds great, and glad we talked though this--if it sounds okay, I'll try to include this in #151.

@lukehollis
Copy link
Contributor Author

Admins can now mark their collections as "Public" in the admin backend.

Apr-15-2021 07-51-24

@lukehollis lukehollis removed their assignment Jul 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants