Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If the storage service url has trailing slash the fetch command will fail #8

Closed
peterVG opened this issue Jun 18, 2020 · 4 comments
Closed

Comments

@peterVG
Copy link
Member

peterVG commented Jun 18, 2020

If the url for a configured storage service contains a trailing / character, then when we come to append the api command here, we'll get a double // which causes the command to fail.

@ross-spencer
Copy link
Contributor

Related #7 the ticket says it all, so as we fix this up and bring in AMClient we might find working with paths like this a lot easier.

@peterVG
Copy link
Member Author

peterVG commented Jul 10, 2020

I can fix this with a simple form validation for now. Refactoring to use AMClient is a good suggestion but not trivial at this stage.

@ross-spencer
Copy link
Contributor

Tiny fix for this and tests here c1eb647 there might be a better long-term solution. This is useful to fix now as it helps with copy and paste.

@ross-spencer
Copy link
Contributor

Continuing that fix here, it needed a little more effort: 852e3d2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants