Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mrb makeDeps (md) is broken #4

Open
lgarren opened this issue Nov 4, 2021 · 3 comments
Open

mrb makeDeps (md) is broken #4

lgarren opened this issue Nov 4, 2021 · 3 comments
Labels
bug Something isn't working

Comments

@lgarren
Copy link
Contributor

lgarren commented Nov 4, 2021

mrb md produces an error. It hasn't been exercised in some time, so this is not a big surprise.

[garren@scisoftbuild01 build_slf7.x86_64]$ mrb md
Traceback (most recent call last):
  File "/scratch/products/mrb/v5_19_05/libexec/makeDep.py", line 285, in 
    system.run()
  File "/scratch/products/mrb/v5_19_05/libexec/makeDep.py", line 104, in run
    self.load_project_dependency_database()
  File "/scratch/products/mrb/v5_19_05/libexec/makeDep.py", line 135, in load_project_dependency_database
    if not self.project_deps.has_key(pkg):
AttributeError: 'dict' object has no attribute 'has_key'

To Reproduce
checkout larsoft and build
in the build directory, type "mrb md"

@lgarren lgarren added the bug Something isn't working label Nov 4, 2021
@lgarren
Copy link
Contributor Author

lgarren commented Nov 4, 2021

It looks like I can fix this simply by running 2to3.

@lgarren
Copy link
Contributor Author

lgarren commented Nov 4, 2021

Um, apparently not. The resulting file is far from complete.

@lgarren
Copy link
Contributor Author

lgarren commented Nov 4, 2021

mrb makeDep.py is a) written in python 2 and b) not compatible with mrb 5. I am able to run it successfully with mrb 4 if I do the following:

mrb b
unsetup python
unsetup sqlite
setup python v2_7_15a
mrb md

Because the larsoft base_dependency_database file has not been updated since Jan. 2019 (and contained references to larsimobj!), I have updated the head of develop with a base_dependency_database file from the larsoft v09_30_00 release.

Here's hoping we can come up with a better solution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant