Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose helpers for decoding and encoding data types #5

Open
knoepfel opened this issue Oct 28, 2021 · 0 comments
Open

Expose helpers for decoding and encoding data types #5

knoepfel opened this issue Oct 28, 2021 · 0 comments
Labels
feature An enhancement to the project

Comments

@knoepfel
Copy link
Contributor

This issue has been migrated from https://cdcvs.fnal.gov/redmine/issues/23668 (FNAL account required)
Originally created by @PetrilloAtWork on 2019-11-29 22:40:11


FHiCL officially supports get'ing and put'ing custom data types via encode() and decode() functions.
In my experience, this is often done parsing a parameter in the standard FHiCL way, and then taking further actions. The most common action I take is to decode() a parameter into a C++ string and then parse it.
FHiCL standard types (including std::string) already do that, and do it right. It would be useful for them to be exposed to the public interface rather than being hidden behind the implementation detail wall.
In alternative, functionally-equivalent functions might be provided (e.g. fhicl::decodeParameter(std::any, std::string&) etc.).
Also, part of the public protocol (encode's return values ps_atom_t and ps_sequence_t) are currently behind the same wall.

@knoepfel knoepfel added the feature An enhancement to the project label Oct 28, 2021
@knoepfel knoepfel added this to Issues Oct 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature An enhancement to the project
Projects
Status: No status
Development

No branches or pull requests

1 participant