Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

d_localtime_r_needs_tzset isn't tested, breaking time.t #43

Open
moben opened this issue Nov 28, 2016 · 1 comment
Open

d_localtime_r_needs_tzset isn't tested, breaking time.t #43

moben opened this issue Nov 28, 2016 · 1 comment

Comments

@moben
Copy link
Contributor

moben commented Nov 28, 2016

time.t fails with

# Failed test 7 - changes to $ENV{TZ} respected at op/time.t line 62
op/time.t ......................................................... Failed 1/72 subtests

here because d_localtime_r_needs_tzset isn't tested by configure. If I define it manually the test passes. (This is on linux, glibc, amd64)

full log is here if needed: https://gist.github.com/moben/7ca323b2814ecaef78a823b0a5724909

@arsv
Copy link
Owner

arsv commented Nov 28, 2016

That would be a runtime test, however 'define' seems to be the safe default value there.
"For portable code, tzset(3) should be called before localtime_r()" — localtime_r(3)

5192e4d

Looks like 'undef' actually works in most cases, that's why it went unnoticed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants