Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

phpcs with several available Drupal* standards #49

Open
kaaresl opened this issue Aug 20, 2014 · 2 comments
Open

phpcs with several available Drupal* standards #49

kaaresl opened this issue Aug 20, 2014 · 2 comments
Labels

Comments

@kaaresl
Copy link
Contributor

kaaresl commented Aug 20, 2014

Problem

drupal/phpcs-standard picks the first available standard matching Drupal.*, so having DrupalPractice installed in tandem with Drupal (coder.module) causes the first to be selected and you loose all rules provided by Drupal.

Suggested solution

One of the following:

  • Provide all standards using phpcs --standard=Drupal,DrupalPractice (Yes, it's possible to provide several).
  • Extract the available standards as a configuration letting the user select which to use.
@kaaresl
Copy link
Contributor Author

kaaresl commented Aug 26, 2014

I have got to learn to read the code better. Or at least look through the available configuration settings. Just found M-x customize-variable drupal/phpcs-standard.

@kaaresl kaaresl closed this as completed Aug 26, 2014
@arnested
Copy link
Owner

😄

I didn't know you could provide several standards. But now that I learned that I started rewriting how standards are handled so that it can be turned into a list of installed standards to choose from.

So I'll reopen for that purpose.

@arnested arnested reopened this Aug 26, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants