Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request]: Add lib/tools/common/__pycache__ to .gitignore #7863

Open
1 task
ig3 opened this issue Feb 22, 2025 · 2 comments
Open
1 task

[Feature Request]: Add lib/tools/common/__pycache__ to .gitignore #7863

ig3 opened this issue Feb 22, 2025 · 2 comments
Assignees
Labels
Feature Request Feature suggestion Good first issue Feel free to contribute :)

Comments

@ig3
Copy link

ig3 commented Feb 22, 2025

Which feature would you like to have?

Yesterday I updated my fork of armbian/build to current main branch and updated the clone on my build server: Ubuntu "22.04.3 LTS (Jammy Jellyfish)" on a qemu virtual server. Then I created a branch for work on an image for a nanopi r2s plus which I have and for which eMMC and one network interface doesn't work with the nanopi r2s image - at least it didn't a few months ago, the last time I had time to work on it.

Today I made an image but after the image was made I checked my git status and found that there is an untracked file: lib/tools/common/__pycache__/. This is the only change. The directory contains one file: bash_declare_parser.cpython-310.pyc. It was last modified a few hours ago, so I don't know what command I ran created it, but it wasn't modified by the last image build.

I checked .gitignore in the project root and it has '/__pycache__/*', which doesn't match the folder in the sub-directory due to the leading slash.

So, maybe I am mistaken and lib/tools/common/__pycache__ should be committed to git, but it seems wrong to commit an __pycache__ directory to me. Or maybe I did something wrong that caused the directory to be created. This is entirely possible: I am not experienced with the build framework and I did have a couple of failed runs before I was able to build an image.

My thinking is that __pycache__/ or something similar should be added to .gitignore, to ignore __pycache__ in sub-directories, but I'm not certain as I am not very familiar with the build framework.

I tried to search for information bout __pycache__ related to the build framework. There are very few results and none that clarify this issue.

Funding

@ig3 ig3 added the Feature Request Feature suggestion label Feb 22, 2025
Copy link
Contributor

Hey @ig3 !

Looks like it's your first time interacting with Armbian here on GitHub.

Welcome and thank you for taking the time to report an issue ❤️.

Don't forget to star ⭐ the repo.

@github-actions github-actions bot added the Good first issue Feel free to contribute :) label Feb 22, 2025
Copy link
Contributor

github-actions bot commented Feb 22, 2025

Jira ticket: AR-2616

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Request Feature suggestion Good first issue Feel free to contribute :)
Development

No branches or pull requests

2 participants