Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor build issue on missing eos sdk folder during compilation #56

Closed
jpsenior opened this issue Nov 19, 2020 · 1 comment · Fixed by #57
Closed

Minor build issue on missing eos sdk folder during compilation #56

jpsenior opened this issue Nov 19, 2020 · 1 comment · Fixed by #57

Comments

@jpsenior
Copy link
Contributor

Hullo!

We have been running into some minor build issues for EosSDK versions since 2.12 (2.12, 2.14, 2.15).

We have locally been patching to simply create the folder during build.sh, but it would be nice if the build script could do this for us.

2020-11-19T20:24:04.970297571Z + STUBS_DIR=/build/arista/arista_sdk/EosSdk-2.15.0
2020-11-19T20:24:04.970338225Z + GO_SRCDIR=/build/arista/arista_sdk/EosSdk-2.15.0/go/src/eossdk
2020-11-19T20:24:04.970348573Z + rm -f /build/arista/arista_sdk/EosSdk-2.15.0/go/src/eossdk/eos
2020-11-19T20:24:04.970953037Z + ln -s /build/arista/arista_sdk/EosSdk-2.15.0/eos /build/arista/arista_sdk/EosSdk-2.15.0/go/src/eossdk/
2020-11-19T20:24:04.97145139Z ln: target '/build/arista/arista_sdk/EosSdk-2.15.0/go/src/eossdk/' is not a directory: No such file or directory
2020-11-19T20:24:04.971850971Z make: *** [/build/arista/arista_sdk/EosSdk-2.15.0/.libs/libeos.so] Error 1
2020-11-19T20:24:04.971868928Z device/arista_sdk/module.mk:6: recipe for target '/build/arista/arista_sdk/EosSdk-2.15.0/.libs/libeos.so' failed
2020-11-19T20:24:04.971870599Z make: *** Waiting for unfinished jobs....

The fix is a simple mkdir -p within build.sh. I'll file a pull request

jpsenior added a commit to jpsenior/EosSdk that referenced this issue Nov 19, 2020
Fixes aristanetworks#56

Simply create the folder before linking into it.
@ruferp
Copy link
Contributor

ruferp commented Nov 19, 2020 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants