Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(experiments): move recorder event to after experiment reconciliation, fixes #4021 #4022

Merged
merged 3 commits into from
Jan 8, 2025
Merged

fix(experiments): move recorder event to after experiment reconciliation, fixes #4021 #4022

merged 3 commits into from
Jan 8, 2025

Conversation

Hellspam
Copy link
Contributor

@Hellspam Hellspam commented Dec 22, 2024 •
edited by zachaller
Loading

fixes: #4021

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this is a chore.
  • The title of the PR is (a) conventional with a list of types and scopes found here, (b) states what changed, and (c) suffixes the related issues number. E.g. "fix(controller): Updates such and such. Fixes #1234".
  • I've signed my commits with DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My builds are green. Try syncing with master if they are not.
  • My organization is added to USERS.md.

@Hellspam
Copy link
Contributor Author

I have not seen any tests for notifications so I did not add any tests.
If needed, I can add testing with some pointers on how to test this.

Locally I've checked that this works and sends the up-to-date Experiment object and not the one with the previous status.

@Hellspam Hellspam changed the title fix: move recorder event to after experiment reconcilation, fixes #4021 fix(experiments): move recorder event to after experiment reconciliation, fixes #4021 Dec 22, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 22, 2024 •
edited
Loading

Published E2E Test Results

  4 files    4 suites   3h 8m 23s ⏱️
113 tests 104 ✅  7 💤 2 ❌
454 runs  424 ✅ 28 💤 2 ❌

For more details on these failures, see this check.

Results for commit e2be26e.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 22, 2024 •
edited
Loading

Published Unit Test Results

2 293 tests   2 293 ✅  3m 0s ⏱️
  128 suites      0 💤
    1 files        0 ❌

Results for commit e2be26e.

♻️ This comment has been updated with latest results.

@zachaller zachaller self-assigned this Jan 2, 2025
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Jan 8, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@zachaller zachaller enabled auto-merge (squash) January 8, 2025 17:47
@zachaller zachaller merged commit c0ca530 into argoproj:master Jan 8, 2025
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zachaller zachaller zachaller approved these changes

Assignees

@zachaller zachaller

Labels
cherry-pick/release-1.8
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Experiment Notification using old rollout/pre-trigger state - related to #3535?
2 participants
@Hellspam @zachaller