Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Capabilities.APIVersions for Kustomize to parse file #3013

Open
0xDones opened this issue Nov 7, 2024 · 3 comments
Open

Remove Capabilities.APIVersions for Kustomize to parse file #3013

0xDones opened this issue Nov 7, 2024 · 3 comments
Labels
enhancement New feature or request no-issue-activity

Comments

@0xDones
Copy link

0xDones commented Nov 7, 2024

Is your feature request related to a problem?

Deploying the Helm Chart using Kustomize (kubectl kustomize . --enable-helm) won't deploy resources that have these kind of check, for example the ServiceMonitors.

Related helm chart

argo-cd

Describe the solution you'd like

Remove the api version checks from the ServiceMonitors and any other resource.

Describe alternatives you've considered

No response

Additional context

For reference, this issue on ingress-nginx Chart describes the exactly same issue: kubernetes/ingress-nginx#7829

@0xDones 0xDones added the enhancement New feature or request label Nov 7, 2024
@mkilchhofer
Copy link
Member

Did you read our statement about this?

See: https://github.com/argoproj/argo-helm?tab=readme-ov-file#charts-use-helm-capabilities

@0xDones
Copy link
Author

0xDones commented Nov 7, 2024

I did after opening the issue, it solved the problem but still feels like "hack" solution. I'm still not sure if there is a lot of advantages of using this check since there are still 2 other flags that need to be set to true before deploying the ServiceMonitors: metrics.enabled=true and metrics.serviceMonitor.enabled=true.

Copy link

github-actions bot commented Jan 7, 2025

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request no-issue-activity
Projects
None yet
Development

No branches or pull requests

2 participants