Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing my library from Library Manager #5781

Closed
wants to merge 1 commit into from

Conversation

cakraawijaya
Copy link
Contributor

I want to delete my library from library manager

I want to delete my library from library manager
@github-actions github-actions bot added the topic: removal Remove library from the list label Jan 15, 2025
Copy link
Contributor

Hi @cakraawijaya.
Your pull request has been detected as something other than a Library Manager submission.
A maintainer will need to review it before it can be merged.

If you intended to submit a library, please check the instructions and update your pull request if necessary:
https://github.com/arduino/library-registry/blob/main/README.md#instructions

Copy link
Contributor

@per1234 per1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @cakraawijaya. Please add a comment here on the pull request thread that provides a detailed explanation for why you wish to remove these libraries.

We are happy to remove libraries on request, but I find it strange that you are requesting their removal when you submitted them only a couple of weeks ago. This, combined with the other nonsensical pull requests you just submitted (#5779, #5780) makes me think that your true goal is not actually the permanent removal of the libraries, but instead that you plan to remove and then re-add the libraries in hopes that it will accomplish some other goal. That is not allowed. We only allow removal requests when the intent is the permanent removal of the library.

@per1234 per1234 added the status: waiting for information More information must be provided before work can proceed label Jan 15, 2025
@cakraawijaya
Copy link
Contributor Author

I am a beginner who wants to contribute. I have previously fixed the MQ2_LPG library in the v1.0.0 tag in my repository, but I am confused when I check in the library manager there is no update, what is the solution? or just need to wait? thank you.

@cakraawijaya cakraawijaya deleted the patch-5 branch January 15, 2025 09:49
@per1234
Copy link
Contributor

per1234 commented Jan 15, 2025

I have previously fixed the MQ2_LPG library in the v1.0.0 tag in my repository

When you make a tag in the library repository, the Library Manager indexer generates an archive file from the contents of the repository as it was at the tagged state in the repository's revision history. The contents of that archive are installed by the Library Manager.

If you later make some changes to the library and want to distribute the new version of the library, you must make a new release, by following the procedure we describe in the documentation:

https://github.com/arduino/library-registry/blob/main/FAQ.md#how-can-i-publish-a-new-release-once-my-library-is-in-the-list

Instead of doing that, you attempted to do an irresponsible thing by deleting the previous v1.0.0 tag and then creating the v1.0.0 tag again at a different point in the repository's revision history. We do not allow changing an existing release one you have made it, as this would result in a very confusing situation for the library users where the library code of that release could be different depending on when they installed the library.

So just make a new release of the library to distribute the changes you made since the time of the original v1.0.0 tag.

@per1234 per1234 added conclusion: invalid Issue/PR not valid and removed status: waiting for information More information must be provided before work can proceed labels Jan 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
conclusion: invalid Issue/PR not valid topic: removal Remove library from the list
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants