From 3ba51cebe97be924a7abfc18e7896e82038154b9 Mon Sep 17 00:00:00 2001
From: Umberto Baldi <34278123+umbynos@users.noreply.github.com>
Date: Tue, 7 Nov 2023 14:51:12 +0100
Subject: [PATCH] Fix autoupdate bundle (#853)

* remove `--keepParent`, it's breaking the autoupdate bundle.
This flag was introduced by mistake, inside gon only `-c -k` were used
https://github.com/mitchellh/gon/blob/2d4f161ccecd1aae878f4416d5ccd622b1b01fdb/package/zip/zip.go#L59

* Revert "remove top level dir it's already there thanks to `ditto --keepParent"

This reverts commit 134d25068c8e8fb980e163761466cc29fe8ec904.
---
 .github/workflows/release.yml | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml
index 1c3c282b8..d0cf50d50 100644
--- a/.github/workflows/release.yml
+++ b/.github/workflows/release.yml
@@ -295,7 +295,7 @@ jobs:
         run: gon -log-level=debug -log-json "${{ env.GON_CONFIG_PATH }}"
 
       - name: Zip output app bundle
-        run: ditto -c -k --keepParent ArduinoCreateAgent.app/ ArduinoCreateAgent.app_${{ matrix.arch }}_notarized.zip
+        run: ditto -c -k ArduinoCreateAgent.app/ ArduinoCreateAgent.app_${{ matrix.arch }}_notarized.zip
 
       - name: Remove gon used for code signing
         run: |
@@ -455,10 +455,13 @@ jobs:
         uses: actions/download-artifact@v3
         with:
           name: ArduinoCreateAgent.app_${{ matrix.arch }}_notarized
+          path: ArduinoCreateAgent.app
 
       - name: unzip artifact
+        working-directory: ArduinoCreateAgent.app
         run: |
           unzip ArduinoCreateAgent.app_${{ matrix.arch }}_notarized.zip
+          rm ArduinoCreateAgent.app_${{ matrix.arch }}_notarized.zip
 
       - name: Install create-dmg
         run: brew install create-dmg